"Add assignment" button makes it add to current category #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds to buttonFuntions.js and home.js, changing the newAssignment function so it adds to the current category filter (and if none is selected just the first category filter), and tracks what the filter is currently. I did this based off a variable and not the filter because it's easier.
just so maintainers don't have to
andOrlando
changed the title
|
also forgot to mention this, but selecting the same category as the one currently selected clears the filter |
Using -1 as the sentinel value improves type safety.
andOrlando
added a commit
that referenced
this pull request
Dec 16, 2020
adds to buttonFuntions.js and home.js, changing the newAssignment function so it adds to the current category filter (and if none is selected just the first category filter), and tracks what the filter is currently. I did this based off a variable and not the filter because it's easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds to buttonFuntions.js and home.js, changing the newAssignment function so it adds to the current category filter (and if none is selected just the first category filter), and tracks what the filter is currently. I did this based off a variable and not the filter because it's easier. Just a small bug kind of.