Changed Aspine header onclick behavior to open grades instead of clock #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request! I see two small issues. Now when you click on the clock in the header, it no longer brings you to the clock page. We want to retain that ability while also adding the ability to click on other parts of the header to bring you back the home page. Additionally, when you click the header, you are brought to the Grades page, but the words "Grades" isn't greyed indicating that you are on that tab. Thanks! |
|
@Daniel-Benzion Thank you for the pull request. Because @MohanMaker fixed the same issue in #177 while also addressing the action items on this pull request, I am going to close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #168 ("Clicking on 'Aspine' goes to clock instead of home page").