Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink district logo on login page #221

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Shrink district logo on login page #221

merged 1 commit into from
Dec 20, 2020

Conversation

psvenk
Copy link
Member

@psvenk psvenk commented Dec 19, 2020

Due to changes to the login page, a district logo (if present) displays at a very large size — this pull request shrinks it to be less obtrusive. This is a subset of the changes in #217 because it seems that we cannot reach a consensus on that in time for version 2.6.1.

Due to changes to the login page, a district logo (if present) displays
at a very large size -- this commit shrinks it to be less obtrusive.
Copy link
Collaborator

@jadebuckwalter jadebuckwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tektaxi tektaxi marked this pull request as ready for review December 19, 2020 23:51
Copy link
Collaborator

@tektaxi tektaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tektaxi tektaxi marked this pull request as draft December 19, 2020 23:52
@psvenk psvenk added this to the 2.6.1 milestone Dec 20, 2020
@kdk1616 kdk1616 marked this pull request as ready for review December 20, 2020 01:09
@kdk1616
Copy link
Collaborator

kdk1616 commented Dec 20, 2020

Looks good. Later on we should add the 1024px CSS from #217. But that is not a priority.

@psvenk psvenk marked this pull request as draft December 20, 2020 03:06
@psvenk psvenk marked this pull request as ready for review December 20, 2020 19:15
@psvenk psvenk merged commit 4b6289e into master Dec 20, 2020
@psvenk psvenk deleted the shrink-logo branch December 20, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants