Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #245

Merged
merged 6 commits into from
Jan 21, 2021
Merged

Update readme #245

merged 6 commits into from
Jan 21, 2021

Conversation

jadebuckwalter
Copy link
Collaborator

Update the readme file to include updated info on the color schemes for
both light and dark mode.

Update the readme file to include updated info on the color schemes for
both light and dark mode.
Change "2020" to "2019-21"
I noticed a few typos/awkward phrases and inconsistencies while reading
this, so I fixed them.
@jadebuckwalter
Copy link
Collaborator Author

Should I also update the "features" section to include some of the new features? I don't think there are any major features that aren't included, so this may not be necessary.

@jadebuckwalter
Copy link
Collaborator Author

Also, should I include the various shades of gray in the readme? It may seem a bit unnecessary but it might be helpful to further contextualize the shades of green in dark mode.

Link to the light and dark color schemes separately under their
respective sections.
Copy link
Member

@psvenk psvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, but here are some comments:

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jadebuckwalter and others added 2 commits January 21, 2021 12:57
Nothing more to say.

Co-authored-by: psvenk <45520974+psvenk@users.noreply.github.com>
Change each feature from title case to sentence case.
@psvenk psvenk self-requested a review January 21, 2021 18:59
@psvenk psvenk added this to the 2.7.0 milestone Jan 21, 2021
Copy link
Member

@psvenk psvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@psvenk psvenk marked this pull request as ready for review January 21, 2021 19:01
@jadebuckwalter jadebuckwalter merged commit 3e4ad5e into Aspine:master Jan 21, 2021
@jadebuckwalter jadebuckwalter deleted the update-readme branch January 21, 2021 19:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants