Style day of week picker #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psvenk
reviewed
Feb 8, 2021
Style the dropdown menu so it looks nicer and uniform to other dropdowns
Remove unnecessary code and add/revise comments
jadebuckwalter
force-pushed
the
day-of-week-picker-style
branch
from
d3ff1aa to
29495cf
Compare
Toggle the appropriate schedule based on the selected day.
|
Some minor fixes remain:
|
On weekdays, display the name of the day on the dropdown instead of "select day"
Point the arrow up when the menu is open, point it down when closed
Add support for an edge case where the day of week is undefined by defaulting to "Select Day"
When you click outside the dropdown when it is open, hide the options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style the dropdown menu so it looks nicer and uniform to other dropdowns