Add times to the schedule #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each period, display the start and end time in the schedule.
|
It would be great if someone who doesn't have an AM class could test this out. |
psvenk
requested changes
Mar 24, 2021
Finding the time for a period is independent of the periods in a student's schedule because the start and end times are in schedule.json; also, remove usage of the comma operator.
psvenk
requested changes
Mar 24, 2021
There was a problem hiding this comment.
I just now refactored the code so that it is more efficient and clean and also works on my schedule, so it looks good to me apart from some stylistic comments: (a) we should display "AM"/"PM" instead of just leaving it implied (we can add a 24-hour time option once #23 is implemented), and (b) an en dash (–) should be used between times, not a hyphen (see Butterick's Practical Typography).
|
By the way, the time formatting can be handled by |
|
@psvenk Great - that seems a lot easier. I can take care of these fixes if you'd like. |
This not only resolves ambiguity arising from 12-hour time without "AM" or "PM" but also localizes the time format (so that, e.g., 24-hour time will be used when the locale specifies it).
|
Looks good to me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each period, display the start and end time in the schedule.