Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwards and backwards #331

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Forwards and backwards #331

merged 2 commits into from
Feb 3, 2022

Conversation

notrodes
Copy link
Collaborator

@notrodes notrodes commented Feb 1, 2022

Closes #224 and it was way easier than I thought it would be.

Copy link
Member

@psvenk psvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One thing to consider: we could assign URL fragments to the history states — e.g., #schedule, #attendance — and switch to the proper tab if a user loads the page with one of these fragments as part of the URL. This makes the tabs function more like separate pages and has the benefit of making the history states transparent to the user (via changes in the page URL). What are your thoughts?

@notrodes
Copy link
Collaborator Author

notrodes commented Feb 3, 2022

The thing with that is that I couldn't come up with a good way to translate between #fragment names and ids for lookup. If you think of a way of gathering and selecting elements by #'s that would be great but I can just brute force it, in a not very programmatic translator, with a series of ifs or a switch.

@notrodes notrodes merged commit e313739 into Aspine:master Feb 3, 2022
@psvenk psvenk added this to the 2.9.0 milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router, using the back and forwards keys
2 participants