Lazy loading #77
Merged
Lazy loading #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using Tabulator to perform the AJAX request that gets the data to populate tableData, perform the AJAX request separately and update the table. This will make it easier to perform separate AJAX requests as each term (Q1, Q2, Q3, Q4) is requested.
1) The schedule-scraping has been commented out of scrape_student in scrape.js, instead exporting scrape_schedule directly. 2) A new endpoint, '/schedule', has been declared in serve.js, from which the schedule can be retrieved as JSON (because it is no longer included in the JSON file from /data). 3) The JavaScript in home.html now performs the schedule request separately with a separate callback function, and clock.js no longer assumes that tableData.schedule must exist if tableData exists. A similar treatment will be given to other components that are scraped until the loading has become sufficiently modular (lazy loading) to make it feasible to retrieve data from past terms and to extend Aspine in other ways in the future.
Same as previous commit, but with the PDF files (Reports tab).
…iting it. This fixes the problem where tableData already contains information, for example pdf_files, which are then erased when /data does 'tableData = response'. This would occur when a user immediately navigates to the 'Reports' page before /data has the chance to complete.
…hat /data returns while the user is on a different tab
|
Wow awesome work! I took care of two small problems that arose from the possibility for /pdf to return before /data. I then added a loader to indicate to users that lazy loading is going on (it could be a confusing otherwise). If you agree with these changes, I think it is ready to merge. |
|
@Ruborcalor These changes look good, thank you for catching those oversights and making fixes. I did notice that the loader was gone and intended to fix it, but for some reason I forgot to do that before creating this PR. I'll just ask @kdk1616 if he has any input before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56. This PR moves the schedule and PDF scrapers out of the main
scrape_studentfunction inscrape.js(which is called from the/dataendpoint) and keeps separate endpoints for them,/scheduleand/pdf.home.htmlhas been updated to perform separate AJAX requests for the schedule and the PDF files (reports), with items only being downloaded as needed. In the case of the schedule, the data are downloaded as soon as the grades have been downloaded or when the user clicks on the "Schedule" tab, so that the clock in the upper left-hand corner shows the current period without the user needing to click on the "Schedule" tab to load the schedule data. In the case of the reports, the data are downloaded only when the user clicks on the "Reports" tab.From my (somewhat limited) testing, this code causes no problems. Please let me know if any of you come across any problems with the new code.