Merge pull request #351 from AutoUncle/bugfix/close-file-handles

Close file handle after uploading
AssetSync · Jul 12, 2017 · 5ffcea6 · 5ffcea6
2 parents a4aaf59 + 78200a8
commit 5ffcea6
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/asset_sync/storage.rb b/lib/asset_sync/storage.rb
@@ -121,9 +121,11 @@ def upload_file(f)
       one_year = 31557600
       ext = File.extname(f)[1..-1]
       mime = MultiMime.lookup(ext)
+      gzip_file_handle = nil
+      file_handle = File.open("#{path}/#{f}")
       file = {
         :key => f,
-        :body => File.open("#{path}/#{f}"),
+        :body => file_handle,
         :public => true,
         :content_type => mime
       }
@@ -168,9 +170,10 @@ def upload_file(f)
 
         if gzipped_size < original_size
           percentage = ((gzipped_size.to_f/original_size.to_f)*100).round(2)
+          gzip_file_handle = File.open(gzipped)
           file.merge!({
                         :key => f,
-                        :body => File.open(gzipped),
+                        :body => gzip_file_handle,
                         :content_encoding => 'gzip'
                       })
           log "Uploading: #{gzipped} in place of #{f} saving #{percentage}%"
@@ -199,7 +202,9 @@ def upload_file(f)
         })
       end
 
-      file = bucket.files.create( file ) unless ignore
+      bucket.files.create( file ) unless ignore
+      file_handle.close
+      gzip_file_handle.close if gzip_file_handle
     end
 
     def upload_files