Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close file handle after uploading #351

Merged
merged 2 commits into from
Jul 12, 2017
Merged

Close file handle after uploading #351

merged 2 commits into from
Jul 12, 2017

Conversation

zinkkrysty
Copy link
Contributor

Fixes #348

Not tested yet.

@zinkkrysty zinkkrysty changed the title Close file after uploading Close file handle after uploading Jul 6, 2017
@PikachuEXE
Copy link
Member

I think you forgot the gzip one
https://github.com/AutoUncle/asset_sync/blob/c7ec7a982d2dda98fb5318d126e9d83c4354a656/lib/asset_sync/storage.rb#L174

@zinkkrysty
Copy link
Contributor Author

I made the change. We are using this in production now. Seems to work fine.

@PikachuEXE PikachuEXE merged commit 5ffcea6 into AssetSync:master Jul 12, 2017
@PikachuEXE
Copy link
Member

Thanks, will be releasing after running test, I can't setup travis build for this repo...

@PikachuEXE
Copy link
Member

2.2.0 released, please have a try
Remember to run test next time, fixed some outdated stubbing due to this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zinkkrysty @PikachuEXE