support webpacker 2.0 #345
Closed
+16
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see #346 for potential alternative |
zinkkrysty
reviewed
Jun 14, 2017
| # RAILS_GROUP and RAILS_ENV are not defined. We need to reload the | ||
| # assets environment in this case. | ||
| # Rake::Task["assets:environment"].invoke if Rake::Task.task_defined?("assets:environment") | ||
| Rake::Task["assets:sync"].invoke if defined?(AssetSync) && AssetSync.config.run_on_precompile |
There was a problem hiding this comment.
are you running assets:sync separately in your project? I needed to make a change so that this task is run after webpacker:compile (when defined). See #341 for my solution, I will update it so it works with Webpacker 2.0 - inspired by your changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #344