-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method add_local_file_paths to config class #347
Conversation
I'm not very familiar with ruby, but what is the difference from #346? Can't we do the same stuff? |
In #346 you can do this: AssetSync.configure do |config|
# The block should return an array of file paths
config.additional_local_file_paths_proc = proc do
# Any code that returns paths of local asset files to be uploaded
# Like Webpacker
Dir[File.join(Webpacker::Configuration.fetch(:public_output_path), '/**/**')]
end
end Problem is if there are other gems trying to integrate with this gem |
Thanks for explanation, great work! |
since my Dir.chdir("public") do
Dir[File.join(Webpacker::Configuration.fetch(:public_output_path), '/**/**')]
end |
That's just an example |
Let me know if this works or not |
Works for me |
This works for me too. |
Works for me too. |
I will release this within next week, if no other major issues |
|
Alternative to #346
Allows multiple list of local file paths to be added
Usage: (in Ruby code)
This new method does not affect existing options
The existing list of local files generated is still the same
Using this new method only add new file paths
Also replaces
Fixes #344