Skip to content

Commit

Permalink
fix: BuyExecution xcm benchmark tests (#1140)
Browse files Browse the repository at this point in the history
* fix: xcm benchmarks failing test

* chore(ci): add `runtime-benchmarks, try-runtime` features in tarpaulin job
  • Loading branch information
ashutoshvarma authored Jan 17, 2024
1 parent d778f12 commit cb25353
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
uses: actions-rs/tarpaulin@v0.1
with:
version: 0.22.0
args: '--workspace -e astar-collator xcm-tools local-runtime shibuya-runtime shiden-runtime astar-runtime integration-tests --exclude-files vendor/* bin/* runtime/* tests/* **/mock.rs **/weights.rs precompiles/utils/*'
args: '--workspace --features try-runtime,runtime-benchmarks -e astar-collator xcm-tools local-runtime shibuya-runtime shiden-runtime astar-runtime integration-tests --exclude-files vendor/* bin/* runtime/* tests/* **/mock.rs **/weights.rs precompiles/utils/*'
out-type: Xml

- name: Code Coverage Summary Report
Expand Down
2 changes: 1 addition & 1 deletion pallets/astar-xcm-benchmarks/src/generic/benchmarking.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ mod benchmarks {
let fee_asset = Concrete(MultiLocation::parent());

let instruction = Instruction::<XcmCallOf<T>>::BuyExecution {
fees: (fee_asset, 100_000_000u128).into(), // should be something inside of holding
fees: (fee_asset, u128::MAX).into(), // should be something inside of holding
// this should not be Unlimited, as xcm-executor will skip buying the
// exceution altogether.
weight_limit: WeightLimit::Limited(Weight::from_parts(1u64, 1024)),
Expand Down
2 changes: 1 addition & 1 deletion pallets/astar-xcm-benchmarks/src/mock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ parameter_types! {
pub const MaxInstructions: u32 = 100;
pub const MaxAssetsIntoHolding: u32 = 64;

pub const WeightPrice: (xcm::latest::AssetId, u128, u128) = (Concrete(TransactAssetLocation::get()), 1_000_000, 1024);
pub WeightPrice: (xcm::latest::AssetId, u128, u128) = (Concrete(Parent.into()), 1_000_000, 1024);
pub const UnitWeightCost: u64 = 10;
}

Expand Down

0 comments on commit cb25353

Please sign in to comment.