Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BuyExecution xcm benchmark tests #1140

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

ashutoshvarma
Copy link
Member

Pull Request Summary

  • Fix a silly mistake in xcm benchmarks mock where fee currency was set worngly.
  • Add runtime-benchmarks and try-runtime features in tarpaulin CI job

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@ashutoshvarma ashutoshvarma added runtime This PR/Issue is related to the topic “runtime”. tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc. labels Jan 17, 2024
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/xcm/src 72% 0%
precompiles/xvm/src 74% 0%
chain-extensions/types/unified-accounts/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/ethereum-checked/src 75% 0%
pallets/xc-asset-config/src 64% 0%
pallets/static-price-provider/src 58% 0%
pallets/dapp-staking-migration/src 49% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/xvm/src 0% 0%
precompiles/assets-erc20/src 81% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/inflation/src 83% 0%
pallets/dapps-staking/src/pallet 86% 0%
pallets/astar-xcm-benchmarks/src 89% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/block-rewards-hybrid/src 91% 0%
chain-extensions/types/assets/src 0% 0%
pallets/dapp-staking-v3/src 87% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/unified-accounts/src 84% 0%
precompiles/dapp-staking-v3/src 90% 0%
primitives/src/xcm 66% 0%
primitives/src 59% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/xvm/src 51% 0%
pallets/dapps-staking/src 90% 0%
precompiles/dapps-staking/src 94% 0%
precompiles/unified-accounts/src 100% 0%
pallets/collator-selection/src 90% 0%
chain-extensions/pallet-assets/src 56% 0%
Summary 79% (4356 / 5538) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit cb25353 into master Jan 17, 2024
10 checks passed
@Dinonard Dinonard deleted the fix/xcm-benchmarks-test branch January 17, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants