This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Maintenance #60
Merged
Maintenance #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to a new CircleCI 2.0 configuration based on the arcanemagus/atom-docker-ci image.
The previous specs appear to have been some sort of custom interface that no longer exists. Implement new specs that test the basic functionality of the linter. Note that it seems `Lint.jl` only ever returns a column range of 0 to 80 currently. Fixes #2.
This needs to inherit the `this` from the calling socket connection.
Arcanemagus
force-pushed
the
arcanemagus/maintenance
branch
from
b0378d8
to
a286326
Compare
The v0.5.2, although it is the version the current Lint.jl is designed for, is unable to contact GitHub to download the package. Switch to v0.6.4 in order to be able to install the package.
This should automatically install for live environments, however it is too slow to re-initialize for each spec.
Fix the `console.debug` statements to actually work, and only print them when Atom is in developer mode.
Julia is _very_ slow to bring in Lint.jl when starting up, increase the spec timeout to 90 seconds from 10 seconds in order to accommodate that.
Arcanemagus
force-pushed
the
arcanemagus/maintenance
branch
from
663f45b
to
ac8da2e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several small changes bringing this package up to a better standing:
uuid4Fixes #2.
Fixes #48.
Fixes #58.