V2 linter API support

.circleci/config.yml

@@ -0,0 +1,110 @@
+version: 2
+
+defaults: &defaults
+  working_directory: /tmp/project
+  docker:
+    - image: arcanemagus/atom-docker-ci:stable
+  steps:
+    # Restore project state
+    - attach_workspace:
+        at: /tmp
+    - run:
+        name: Create VFB for Atom to run in
+        command: /usr/local/bin/xvfb_start
+    - run:
+        name: Atom version
+        command: ${ATOM_SCRIPT_PATH} --version
+    - run:
+        name: APM version
+        command: ${APM_SCRIPT_PATH} --version
+    - run:
+        name: Package APM package dependencies
+        command: |
+          if [ -n "${APM_TEST_PACKAGES}" ]; then
+            for pack in ${APM_TEST_PACKAGES}; do
+            ${APM_SCRIPT_PATH} install "${pack}"
+            done
+          fi;
+    - run:
+        name: Package dependencies
+        command: ${APM_SCRIPT_PATH} install
+    - run:
+        name: Cleaning package
+        command: ${APM_SCRIPT_PATH} clean
+    - run:
+        name: Package specs
+        command: ${ATOM_SCRIPT_PATH} --test spec
+    # Cache node_modules
+    - save_cache:
+        paths:
+          - node_modules
+        key: v1-dependencies-{{ .Branch }}-{{ checksum "package.json" }}-{{ checksum "package-lock.json"}}
+
+jobs:
+  checkout_code:
+    <<: *defaults
+    docker:
+      - image: circleci/node:latest
+    steps:
+      - checkout
+      # Restore node_modules from the last build
+      - restore_cache:
+          keys:
+          # Get latest cache for this package.json and package-lock.json
+          - v1-dependencies-{{ .Branch }}-{{ checksum "package.json" }}-{{ checksum "package-lock.json"}}
+          # Fallback to the current package.json
+          - v1-dependencies-{{ .Branch }}-{{ checksum "package.json" }}-
+          # Fallback to the last build for this branch
+          - v1-dependencies-{{ .Branch }}-
+          # Fallback to the last available master branch cache
+          - v1-dependencies-master-
+          # Don't go further down to prevent dependency issues from other branches
+      # Save project state for next steps
+      - persist_to_workspace:
+          root: /tmp
+          paths:
+            - project
+  lint:
+    <<: *defaults
+    docker:
+      - image: circleci/node:lts
+    steps:
+      # Restore project state
+      - attach_workspace:
+          at: /tmp
+      - run:
+          name: Node.js Version
+          command: node --version
+      - run:
+          name: NPM Version
+          command: npm --version
+      - run:
+          name: Install any remaining dependencies
+          command: npm install
+      - run:
+          name: Compile sources
+          command: npm run compile
+      - run:
+          name: Lint code
+          command: npm run lint
+  stable:
+    <<: *defaults
+  beta:
+    <<: *defaults
+    docker:
+      - image: arcanemagus/atom-docker-ci:beta
+
+workflows:
+  version: 2
+  test_package:
+    jobs:
+      - checkout_code
+      - lint:
+          requires:
+            - checkout_code
+      - stable:
+          requires:
+            - lint
+      - beta:
+          requires:
+            - lint

README.md

@@ -28,8 +28,7 @@ You can configure linter-slim by editing ~/.atom/config.cson (choose Open Your C
 
 ```
 'linter-slim':
-  'executableDir': null # slimrb directory path.
-  'binaryName': slimrb # slimrb binary name.
+  'slimrbExecutablePath': slimrb # slimrb executable path.
   'rails': true # generates rails compatible code.
   'library': [] # load library or plugin (e.g. slim/plugin).
 ```

lib/linter-slim.js

@@ -0,0 +1,136 @@
+'use babel';
+
+// eslint-disable-next-line import/no-extraneous-dependencies, import/extensions
+import { CompositeDisposable } from 'atom';
+
+let helpers;
+
+// Deprecated syntax:
+const REGEX = /.*(SyntaxError|Deprecated).*: (.+)\n.+, Line (\d+), Column (\d+)/g;
+
+const severityMapping = {
+  deprecated: 'warning',
+  syntaxerror: 'error',
+};
+
+const loadDeps = () => {
+  if (!helpers) {
+    helpers = require('atom-linter');
+  }
+};
+
+const parseCompileOutput = (output, filePath, editor) => {
+  const messages = [];
+
+  let match = REGEX.exec(output);
+  while (match !== null) {
+    const severity = severityMapping[match[1].toLowerCase()] || 'warning';
+    const line = Number.parseInt(match[3], 10) - 1;
+    const col = Number.parseInt(match[4], 10) - 1;
+    const excerpt = `${match[1]}: ${match[2]}`;
+    messages.push({
+      severity,
+      excerpt,
+      location: {
+        file: filePath,
+        position: helpers.generateRange(editor, line, col),
+      },
+    });
+    match = REGEX.exec(output);
+  }
+  return messages;
+};
+
+module.exports = {
+  activate() {
+    this.idleCallbacks = new Set();
+    let depsCallbackID;
+    const installLinterReekDeps = () => {
+      this.idleCallbacks.delete(depsCallbackID);
+      if (!atom.inSpecMode()) {
+        require('atom-package-deps').install('linter-slim');
+      }
+      loadDeps();
+    };
+    depsCallbackID = window.requestIdleCallback(installLinterReekDeps);
+    this.idleCallbacks.add(depsCallbackID);
+
+    this.subscriptions = new CompositeDisposable();
+    this.subscriptions.add(
+      atom.config.observe(
+        'linter-slim.slimrbExecutablePath',
+        (value) => { this.slimrbExecutablePath = value; },
+      ),
+      atom.config.observe(
+        'linter-slim.rails',
+        (value) => { this.rails = value; },
+      ),
+      atom.config.observe(
+        'linter-slim.library',
+        (value) => { this.library = value; },
+      ),
+    );
+  },
+
+  deactivate() {
+    this.idleCallbacks.forEach(callbackID => window.cancelIdleCallback(callbackID));
+    this.idleCallbacks.clear();
+    this.subscriptions.dispose();
+  },
+
+  provideLinter() {
+    return {
+      name: 'slimrb',
+      grammarScopes: ['text.slim'],
+      scope: 'file',
+      lintsOnChange: true,
+      lint: async (editor) => {
+        loadDeps();
+
+        const filePath = editor.getPath();
+        if (!filePath) {
+          return null;
+        }
+
+        const args = [];
+        args.push('--compile');
+
+        if (this.rails) {
+          args.push('--rails');
+        }
+
+        if (Array.isArray(this.library) && this.library.length) {
+          args.push('--require', this.library.join(' '));
+        }
+
+        args.push(filePath);
+
+        const execOptions = {
+          stream: 'stderr',
+          uniqueKey: `linter-slim::${filePath}`,
+          allowEmptyStderr: true,
+        };
+
+        let output;
+        try {
+          output = await helpers.exec(this.slimrbExecutablePath, args, execOptions);
+        } catch (e) {
+          if (e.message === 'Process execution timed out') {
+            atom.notifications.addInfo('linter-slim: `slimrb` timed out', {
+              description: 'A timeout occured while executing `slimrb`, it could be due to lower resources '
+                           + 'or a temporary overload.',
+            });
+          } else {
+            atom.notifications.addError('linter-slimrb: Unexpected error', { description: e.message });
+          }
+          return null;
+        }
+
+        // Process was canceled by newer process
+        if (output === null) { return null; }
+
+        return parseCompileOutput(output, filePath, editor);
+      },
+    };
+  },
+};