Skip to content

Commit

Permalink
Remove Appending and Basics. finos#93, finos#96
Browse files Browse the repository at this point in the history
  • Loading branch information
AttilaMihaly committed Jul 9, 2020
1 parent f339802 commit 802b8cc
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 69 deletions.
3 changes: 3 additions & 0 deletions docs/error-append-not-supported.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The ++ operator assumes a type inferencer that can tell the difference between String and List. These are the only
two types that are part of the `appendable` type-class. Until the type inferencer is available we will error out to
remove ambiguity.
9 changes: 4 additions & 5 deletions src/Morphir/Elm/Frontend.elm
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,11 @@ import Morphir.IR.Package as Package
import Morphir.IR.Path as Path exposing (Path)
import Morphir.IR.QName as QName
import Morphir.IR.SDK as SDK
import Morphir.IR.SDK.Appending as Appending
import Morphir.IR.SDK.Bool as Bool
import Morphir.IR.SDK.Comparison as Comparison
import Morphir.IR.SDK.Composition as Composition
import Morphir.IR.SDK.Equality as Equality
import Morphir.IR.SDK.Float as Float
import Morphir.IR.SDK.Function as Function
import Morphir.IR.SDK.Int as Int
import Morphir.IR.SDK.List as List
import Morphir.IR.SDK.Number as Number
Expand Down Expand Up @@ -1029,7 +1028,7 @@ mapOperator sourceLocation op =
Ok <| Comparison.greaterThanOrEqual sourceLocation

"++" ->
Ok <| Appending.append sourceLocation
Err [ NotSupported sourceLocation "The ++ operator is currently not supported. Please use String.append or List.append. See docs/error-append-not-supported.md" ]

"+" ->
Ok <| Number.add sourceLocation
Expand All @@ -1050,10 +1049,10 @@ mapOperator sourceLocation op =
Ok <| Number.power sourceLocation

"<<" ->
Ok <| Composition.composeLeft sourceLocation
Ok <| Function.composeLeft sourceLocation

">>" ->
Ok <| Composition.composeRight sourceLocation
Ok <| Function.composeRight sourceLocation

"::" ->
Ok <| List.construct sourceLocation
Expand Down
26 changes: 0 additions & 26 deletions src/Morphir/IR/SDK/Appending.elm

This file was deleted.

38 changes: 0 additions & 38 deletions src/Morphir/SDK/Basics.elm

This file was deleted.

0 comments on commit 802b8cc

Please sign in to comment.