Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove basics, since all functionality should be in appropriate modules. #96

Closed
DamianReeves opened this issue Jun 15, 2020 · 0 comments · Fixed by #101
Closed

Remove basics, since all functionality should be in appropriate modules. #96

DamianReeves opened this issue Jun 15, 2020 · 0 comments · Fixed by #101
Assignees
@AttilaMihaly

Comments

@DamianReeves
Copy link
Member

https://github.com/Morgan-Stanley/morphir-elm/blob/2dfd49aa61448374d4f9045e7aa54ffc660b88c9/src/Morphir/SDK/Basics.elm#L1
@AttilaMihaly AttilaMihaly self-assigned this Jul 9, 2020
AttilaMihaly added a commit to AttilaMihaly/morphir-elm that referenced this issue Jul 9, 2020
@AttilaMihaly
Remove Appending and Basics. finos#93, finos#96
802b8cc
@AttilaMihaly AttilaMihaly mentioned this issue Jul 9, 2020
Merged
@AttilaMihaly AttilaMihaly linked a pull request Jul 9, 2020 that will close this issue
Refactor SDK to fix multiple issues #101
Merged
KindsonTheGenius pushed a commit to KindsonTheGenius/morphir-elm that referenced this issue Apr 12, 2023
@AttilaMihaly
Remove Appending and Basics. finos#93, finos#96
c7962d9
sfc-gh-lfallasavendano added a commit to Snowflake-Labs/morphir-elm that referenced this issue Dec 13, 2023
@sfc-gh-lfallasavendano
Changes to improve compilation for Calculations.elm (finos#96)
2e4847e 
* Changes to improve compilation for `Calculations.elm`

Adds support for:

- Different set of function mappings when converting a function
  identified as Scala-only
- Convert empty DataFrame (still pending issue with session object)
- Adds several simple mappings for `Calculations.elm`: `List.maximum` ,
  `max`, `min`

* Code review fixes and fix List.sum with null values
sfc-gh-lfallasavendano added a commit to Snowflake-Labs/morphir-elm that referenced this issue Dec 13, 2023
@sfc-gh-lfallasavendano
Changes to improve compilation for Calculations.elm (finos#96)
8293644 
* Changes to improve compilation for `Calculations.elm`

Adds support for:

- Different set of function mappings when converting a function
  identified as Scala-only
- Convert empty DataFrame (still pending issue with session object)
- Adds several simple mappings for `Calculations.elm`: `List.maximum` ,
  `max`, `min`

* Code review fixes and fix List.sum with null values
sfc-gh-lfallasavendano added a commit to Snowflake-Labs/morphir-elm that referenced this issue Jan 2, 2024
@sfc-gh-lfallasavendano
Changes to improve compilation for Calculations.elm (finos#96)
a2ef644 
* Changes to improve compilation for `Calculations.elm`

Adds support for:

- Different set of function mappings when converting a function
  identified as Scala-only
- Convert empty DataFrame (still pending issue with session object)
- Adds several simple mappings for `Calculations.elm`: `List.maximum` ,
  `max`, `min`

* Code review fixes and fix List.sum with null values
sfc-gh-lfallasavendano added a commit to Snowflake-Labs/morphir-elm that referenced this issue Jan 8, 2024
@sfc-gh-lfallasavendano
Changes to improve compilation for Calculations.elm (finos#96)
7bcce74 
* Changes to improve compilation for `Calculations.elm`

Adds support for:

- Different set of function mappings when converting a function
  identified as Scala-only
- Convert empty DataFrame (still pending issue with session object)
- Adds several simple mappings for `Calculations.elm`: `List.maximum` ,
  `max`, `min`

* Code review fixes and fix List.sum with null values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AttilaMihaly AttilaMihaly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor SDK to fix multiple issues AttilaMihaly/morphir-elm
2 participants
@DamianReeves @AttilaMihaly