This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Pass retry through for client handle validation #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this change https://demo.audius.co/jowlee-user-handle |
sliptype
approved these changes
Oct 27, 2022
audius-infra
pushed a commit
that referenced
this pull request
Oct 29, 2022
[07e1225] [C-1385] Stream mp3 instead of segments (#2147) Andrew Mendelsohn [930c11c] Truncate balance in account-drawer (#2197) Dylan Jeffers [14c37db] Add disabed tooltip text for hidden tracks tab in artist dashboard (#2196) Kyle Shanks [60be197] [C-1376] Kickoff mobile upload (#2193) Dylan Jeffers [1205956] Pass retry through for client handle validation (#2192) Joseph Lee [2053951] fix artist link badge alignment (#2189) nicoback2 [fc65758] Fix mobile lint (#2190) Sebastian Klingler [a9e1873] [PAY-709][PAY-704][PAY-702][PAY-700][PAY-696][PAY-692][PAY-691] Various Stripe OnRamp Fixes pt 2 (#2185) Marcus Pasell [9789952] [C-1375] Fix push notification navigation (#2184) Dylan Jeffers [1bf06cc] [C-1377] Move cover photo button to top (#2186) Raymond Jacobson [9b9570f] Bump ios to 1.1.36 (#2188) Sebastian Klingler [5d5117d] Use Hermes for iOS; allow enabling/disabling locally C-1334 (#2177) nicoback2 [109d34b] Avoid `handleInUse` libs function bc it hits poa (#2183) Sebastian Klingler [7ffce1b] [C-1359] Prevent double navigation on android, plus StatusBar fixes (#2182) Sebastian Klingler [760bb5d] [C-1370] Fix app initialization sequence and assumptions for offline and online startup (#2164) Andrew Mendelsohn [b7364a9] [PAY-703][PAY-698][PAY-699][PAY-686] Various Stripe Fixes pt 1 (#2176) Marcus Pasell [8ba8ccb] Bump sdk to 1.0.19 (#2181) Isaac Solo [bd0f1fe] [C-1369] Fix account screen crash on android (#2180) Sebastian Klingler [e241f9c] [C-1261] Android sign on overflow (#2171) Sebastian Klingler [edd5408] Fix notification subscriptions (#2167) Raymond Jacobson [089b283] [C-1349] Improve StatusBar colors (#2175) Sebastian Klingler [ba80376] Fix typecheck (#2179) Raymond Jacobson [1bb0ab0] [C-1371, C-1372] Address mobile-navbar QA issues #2 (#2173) Dylan Jeffers [4f53032] Update libs (#2178) Raymond Jacobson [7a8a207] Dual writes when setting artist pick (#2128) Michelle Brier [25954c3] Bump @audius/sdk to 1.0.16 (#2168) Sebastian Klingler [dfab0c2] Update nethermind provider to https (#2174) Isaac Solo [d1e8c1f] Update stage config to nethermind RPC (#2172) Isaac Solo [3da52ee] [C-1302] Fix blank profile picture background color (#2166) Dylan Jeffers [be0a1d2] Fix useLocalStorage hook to use getItem rather than getValue (#2170) Marcus Pasell [1bc59fc] Call getUserListenCountsMonthly in client artist dashboard (#2157) sabrina-kiam [a8617f8] [C-1368, C-1354, C-1364] Address mobile-nav qa (#2165) Dylan Jeffers [fefd3f4] SEO updates (#2162) Joseph Lee [c77558b] Put recovery flow behind feature flag (#2163) Marcus Pasell [56109b4] [PAY-680] Fix BuyAudio recovery success modal (#2110) Marcus Pasell
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Iteration on #2183
Because
404response codes trigger a discovery node reelection, the check for user not existing will trigger this logic and results in longer method response times.This change is to pass along a flag for
retryso that checking for an existing handle will not trigger reslection and be instant!Not sure if there's a mobile component to this that I'm missing @sliptype
Fixes PLAT-432
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Ran locally against stage and validated that no re-selection were happening for non-existent handles.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.