This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[C-1452] Implement release-date field #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjeffers
requested review from
a team and
nicoback2
and removed request for
a team
amendelsohn
approved these changes
Nov 11, 2022
Comment on lines
20
to
24
| return ( | ||
| date.getDate() === today.getDate() && | ||
| date.getMonth() === today.getMonth() && | ||
| date.getFullYear() === today.getFullYear() | ||
| ) |
There was a problem hiding this comment.
😅 it really feels like there should be an easier way, but this totally works. No complaints
There was a problem hiding this comment.
There def is I'll use moment
| textTransform: 'uppercase' | ||
| }, | ||
| divider: { | ||
| marginHorizontal: spacing(-4) |
|
|
||
| return ( | ||
| <> | ||
| <TouchableOpacity style={styles.root} onPress={handlePress}> |
There was a problem hiding this comment.
nit: root feels slightly misleading
maybe best fixed by moving the divider up a level?
audius-infra
pushed a commit
that referenced
this pull request
Nov 12, 2022
[ad230d1] v1.4.0 (#2242) Sebastian Klingler [dc11096] Stop propagation on repost button click in tracks tables (#2249) Kyle Shanks [5964998] Update push notification types, update notif navigation hook, and remove userInteraction check in onNotification method (#2247) Kyle Shanks [decabd2] [C-1461] Implement license-type/isrc upload flow (#2248) Dylan Jeffers [9e84248] [C-1452] Implement release-date field (#2246) Dylan Jeffers [8a0c7a8] Fix race condition checking stream_mp3 feature flag (#2244) Andrew Mendelsohn [36d53b0] Don't delete sourcemaps on sync to s3 (#2243) Sebastian Klingler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements release-date field
RPReplay_Final1668107991.mov