This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Update push notification types, update notif navigation hook, and remove userInteraction check in onNotification method #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliptype
approved these changes
Nov 10, 2022
| @@ -196,6 +234,70 @@ export type MilestoneNotification = BaseNotification & | |||
| } | |||
| ) | |||
|
|
|||
| export type MilestoneFollowPushNotification = { | |||
| // TODO: Not the full structure. Need to verify the fields that come back from identity | |||
There was a problem hiding this comment.
Do we still need all these todos?
There was a problem hiding this comment.
Yea they're helpful for people walking around this code to know what is complete vs half baked
…ove userInteraction check in onNotification method
Kyle-Shanks
force-pushed
the
kj-Update-push-notifications-flow
branch
from
91be2fd
to
8d410ec
Compare
audius-infra
pushed a commit
that referenced
this pull request
Nov 12, 2022
[ad230d1] v1.4.0 (#2242) Sebastian Klingler [dc11096] Stop propagation on repost button click in tracks tables (#2249) Kyle Shanks [5964998] Update push notification types, update notif navigation hook, and remove userInteraction check in onNotification method (#2247) Kyle Shanks [decabd2] [C-1461] Implement license-type/isrc upload flow (#2248) Dylan Jeffers [9e84248] [C-1452] Implement release-date field (#2246) Dylan Jeffers [8a0c7a8] Fix race condition checking stream_mp3 feature flag (#2244) Andrew Mendelsohn [36d53b0] Don't delete sourcemaps on sync to s3 (#2243) Sebastian Klingler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lots of small updates to get push notification navigation working. The biggest change was the removal of the userInteraction check in the onNotification function. Also added more types and a notif type enum for push notifications
Dragons
The removal of the userInteraction check could cause some unexpected behavior so I'll keep an eye out for that
How Has This Been Tested?
Lots of manual testing, lots more to do
How will this change be monitored?
N/A
Feature Flags
N/A