Move client to API Trending #23

piazzatron · 2020-09-25T00:59:01Z

Trello Card Link

https://trello.com/c/h5UW0oXf

Description

Use v1/full/tracks/trending for API.

This needs https://github.com/AudiusProject/audius-protocol/pulls to merge.

Current Known Issues

Trending keeps trying to load more tiles at 100 entries (possible lineup bug?)
FIXED Switching to a different time-range and then selecting a new genre disables the previous time range tab buttons

Dragons

🚨 Trending

How Has This Been Tested?

Ran local discprov pointed to prod discovery snapshot, passed that in as override endpoint for APIClient

audius-infra · 2020-09-25T01:09:23Z

Preview this change https://frontend-demo.audius.co/piazz-api-trending

jowlee

Nice work @piazzatron ! Looks fantastic.

src/containers/track-page/TrackPageProvider.tsx

jowlee · 2020-09-25T16:08:52Z

src/containers/track-page/store/retrieveTrending.ts

+  const currentGenre = yield select(getTrendingGenre)
+
+  // If we changed genres, do nothing
+  if (currentGenre !== genre) return []


Should this matter if the generator code is in a takeLatest saga, then it would be canceled which is effectively the same thing? I assume this is for the case when you switch genres quickly before the first saga got to this point?

good point, let's merge now and table this. doesn't hurt to have

jowlee · 2020-09-25T16:18:40Z

src/services/AudiusBackend.js

@@ -1041,25 +1055,6 @@ class AudiusBackend {
    }
  }

-  static async getTrendingTracks({ genre, offset, limit, timeRange }) {


@raymondjacobson we are getting rid of the optimistic load with this change, just wanted to flag. Should be fine if dp selection isn't slow.

nvm there is eager selection in the new api 😍 thx @piazzatron

src/services/audius-api-client/AudiusAPIClient.ts

* Successfully hitting API * First pass at consuming API successful * Remove scoring and ordering from store * Clean up APIClient * Move APIClient * Handle environments better, add in URL construction * Use libs selected discprov in AudiusAPIClient * Use eager discprov selection in APIClient * Polish * More polish * Fix apiClient.init() saga bug * Handle trending response errors * Fix trending tabs issue * Clean up Co-authored-by: Raymond Jacobson <ray@audius.co>

* Update numeric check in TokenValueInput * 0.2.11

* init create-react-library@2.6.7 * Initial commit * Add storybook and Scrubber * Update readme * Fixups * Update readme * Update image size * Update scrubber to fix staleness while dragging bug * Fixup example app * Fix scrubber and rollup config * Clean up * Clean up hook * Update readme * Cleanup scrubber * Rename uniqueKey * Clean up and fix scrubber touch events/safari issues * Add isDisabled back * Bump version * Fix scrubber timestamps (#2) * Fix scrubber for longer than one hour * 0.1.2 * Reformat * Add window focus event listener to fix scrubber (#3) * Add window focus event listener to fix scrubber * 0.1.3 * Add timeData ref * Remove usecallback * Add dark mode to stems (#4) * Add dark mode to stems * 0.1.4 * Bedtime (#5) * Scrubber changes for bedtime * Fix bedtime styles * Add disabled check Co-authored-by: Michael Piazza <michael.piazza.mp@gmail.com> * Add button & icons (#6) * Add Button Component * Clean up and fix lint * Fix iconShare * Export ButtonProps * 0.1.6-dev.0 * Add memo and remove listener * Fix lint situation * Clean up styles and add hooks * Remove memo * 0.1.6 * Extract css (#7) * Extract css separately * 0.2.0 * Add website and donate icons (#8) * Add dwebsite and donate icons * 0.2.1 * Added Trending & campfire icons & udpated pkg lock * 0.2.2 * Updated campfire/trending icons * Add handle color override & fix global var support (#10) * Add handle color override * 0.2.3 * Rework font support and fix inclusion of global vars * Remove logo * Update README.md (#12) * Update README.md * Bold notice text * Add LICENSE (#13) * Fix button animations, exposing animation vars (#14) * 0.2.4 (#15) * Adds modal and tab slider component (#16) * Adds modal and tab slider * Nest modal in another div * 0.2.5 (#17) * Add token value slider and input (#18) * 0.2.6 (#19) * Fix btn and slider (#20) * Fix btn and slider * 0.2.7 * Allow styling of TokenValueSlider bar (#21) * Allow styling of slider bar * 0.2.8 * Add specific color overrides for TokenValueSlider (#22) * Add specific color overrides for TokenValueSlider * 0.2.9 * Fix css var identifier * 0.2.10 * Numeric check in TokenValueInput (#23) * Update numeric check in TokenValueInput * 0.2.11 * Add z-index prop to modal (#24) * Add z-index to modal * 0.2.12 * Fix bug in modal (#25) * Rework modal to support all client use cases (#26) * Add scroll counter to modal itself * Fix up modal to support dapp * Fix useClickOutside catch and useGlobal for scroll count * Use useEffect to set initial * Add useEffect and lint * 0.3.0 (#27) * Fix click outside bug in modal (#28) * 0.3.1 (#29) * [AUD-17] useGlobal fix (#31) * 0.3.2-dev.0 * 0.3.2 * [AUD-17] Fix use global memoization * [AUD-9] Fix modal multi-line title on Safari (#30) * Use modal absolute position only on ios safari (#32) * Use absolute position only on ios safari * 0.3.3 * Fix typo * [AUD-112] Fix scrollable modals on iOS (#33) * Fix modal cleaup bg overflow (#35) * Fix modal cleaup bg overflow * Update comment on modal cleanup * 0.3.4 (#34) * Matrix Button Fix (#36) * Matrix fix * 0.3.5 * Additional changes * Add crown icon (#37) * Add crown * 0.3.6 * Slider Changes (#38) * Tab Slider changes * 0.3.7 * Change overflow to auto instead of scroll to hide if not needed (#39) * 0.3.8 (#40) * Expose shadow (#41) * Expose shadow * Update slider vars * 0.3.9 * Update storybook (#42) * Add deployer cut and minimum icons (#43) * 0.3.10 (#44) * Add TikTok icons (#45) * Add TikTok icons * Update inverted icon * 0.3.11 (#46) * Add Popup and PopupMenu (#47) * Update storybook * Update directory structure, nesting components * Add linting for import order and default exports * Add Popup * Add PopupMenu * Fix icon styling * Update paths * [WIP] Update PopupMenu * Minor tweaks to popup * Improve popup styling and logic * Remove duplicate Button.stories.tsx * Remove duplicate Scrubber.stories.tsx * Implement changes from PR comments * Add listener to close Popup on escape * Add back missing scrubber handle height (#48) * Add forward refs to Popup and PopupMenu (#49) * Add a forward ref to Popup and PopupMenu * Use named functions so ref-forwarded components are named in dev tools * 0.3.12 (#50) * Add eth and sol logos (#51) * 0.3.13 (#52) * Use react-spring transition config to animate popup (#53) * Add ProgressBar component (#54) * Add ProgressBar component * Update ProgressBar component to support BN and use BN under the hood * Add ref to Modal (#55) * 0.3.14 (#56) * Export ProgressBar component and bump version to 0.3.15 (#57) * Update TabSlider component (#58) * Add lock icon (#60) * Update LICENSE (#59) * 0.3.16 (#61) * [AUD-1026] Prevent escape from doing anything when a modal is closed (#63) * Update icon verified to have a path for the check mark (#62) * [AUD-900] Improve popup component (#64) * [AUD-900] Improve popup component * Address comments * 0.3.17 (#65) * Fix null types (#69) * 0.3.18 (#70) * Pin react version (#71) * Pin react version * Update react scripts * Upgrade to react@17.0.2 (#77) * [AUD-1351] Improve bundle size (#78) * Fix disabled button, update install instructions (#81) * 0.3.19 (#83) * [AUD-1359] Fix button label and buttonType (#84) * [AUD-1362] Fix modal a11y (#85) - Adds dialog role - Adds aria-labelledby and aria-describedby for title and subtitle * 0.3.20 (#86) [f2c470b] [AUD-1362] Fix modal a11y (#85) Dylan Jeffers [5d78444] [AUD-1359] Fix button label and buttonType (#84) Dylan Jeffers * Add gradient colors to theme vars (#87) * [AUD-1394] Fix window resize modal bug (#88) * 0.3.21 (#89) * Add Icons and Svg Backgrounds stories (#92) * add icons story * add source Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Rename Tabslider -> SegmentedControl; add Modal sub components (#93) * rename tabslider to segmentedcontrol * add modal story and modalContent component * file name fix * decomp Modal into sub components * changes to modal design, add icon folder * review * get rid of extra lines Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * small primary button update (#94) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.22 (#95) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * fix icons fill colors (#100) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.23 (#101) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * fix icons fill colors and add outlined variant of folder icon (#103) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.24 (#104) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Add Scrollbar component (#107) * add scrollbar component * fix import Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.25 (#109) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Add polyfill for resize observer (#110) * add polyfill for resize observer * add dep * pin dep Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.26 (#111) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * smoll css changes for scrollbar (#112) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.27 (#115) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * modal changes and add icon button (#113) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Upgrade storybook and add A11y add on (#114) * upgrade storybook and add a11y * run prettier eslintrc Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.28 (#116) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Add on blur callback and isWhole prop for whole numbers (#118) Co-authored-by: Saliou Diallo <saliou@audius.co> * 0.3.29 (#119) Co-authored-by: Saliou Diallo <saliou@audius.co> * Set button text to be static white on hover and add button icon transition (#122) * 0.3.30 (#123) * Add primary-secondary-text-color and update PopupMenu and Button text and icon colors to use it (#124) * 0.3.31 (#125) * Add role and aria-valuenow attributes to ProgressBar (#126) * 0.3.32 (#127) * add at sign icon (#128) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.33 (#129) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * fix disabled button states (#130) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.34 (#131) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * add transforms file to dist css (#132) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.35 (#133) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Hide scrollbar after delay [C-550] (#134) * hide scrollbar after delay * change transition * more specificity * fix id * remove comment Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.36 (#135) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Use click instead of mousedown for listener (#136) * Use click instead of mousedown for listener * Only dismiss on click outside if modal is open * Fix boolean logic, add comment * edit comment * 0.3.37 (#137) * Add stems link to the readme Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: Michael Piazza <michael.piazza.mp@gmail.com> Co-authored-by: jowlee <joeylee0925@gmail.com> Co-authored-by: Sebastian Klingler <sliptype@gmail.com> Co-authored-by: Marcus Pasell <rickyrombo@users.noreply.github.com> Co-authored-by: Dylan Jeffers <dylan@audius.co> Co-authored-by: nicoback2 <36916764+nicoback2@users.noreply.github.com> Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Saliou Diallo <sddioulde@hotmail.com> Co-authored-by: Saliou Diallo <saliou@audius.co>

Wait for track to render

* Fix playback * Put back dev env * Fix error

piazzatron added 10 commits September 22, 2020 18:03

Successfully hitting API

8470ce0

First pass at consuming API successful

f990051

Remove scoring and ordering from store

6f88329

Clean up APIClient

439b9c9

Move APIClient

577c7d4

Handle environments better, add in URL construction

ea2baa4

Use libs selected discprov in AudiusAPIClient

27221c7

Use eager discprov selection in APIClient

9cc26c5

Polish

9251826

More polish

455c48d

piazzatron requested a review from jowlee September 25, 2020 00:59

Fix apiClient.init() saga bug

6373892

piazzatron added 2 commits September 24, 2020 18:09

Handle trending response errors

1598229

Fix trending tabs issue

4f5d450

jowlee approved these changes Sep 25, 2020

View reviewed changes

piazzatron requested review from raymondjacobson and jowlee September 25, 2020 19:07

Clean up

aea1937

raymondjacobson merged commit 36b9ab4 into master Sep 26, 2020

raymondjacobson deleted the piazz-api-trending branch September 26, 2020 01:06

sddioulde pushed a commit that referenced this pull request Sep 29, 2021

Handle notif reminder prompt (#23)

132872c

sliptype pushed a commit that referenced this pull request Feb 11, 2022

Handle notif reminder prompt (#23)

9d46ffb

sliptype pushed a commit that referenced this pull request Feb 12, 2022

Handle notif reminder prompt (#23)

269d70e

Kyle-Shanks pushed a commit that referenced this pull request Jun 8, 2022

Numeric check in TokenValueInput (#23)

b73f606

* Update numeric check in TokenValueInput * 0.2.11

sliptype pushed a commit that referenced this pull request Mar 14, 2023

Merge pull request #23 from AudiusProject/jowlee-wait-track-render-play

7d6e451

Wait for track to render

raymondjacobson added a commit that referenced this pull request Jun 27, 2023

Fix playback (#23)

d07f3f0

* Fix playback * Put back dev env * Fix error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move client to API Trending #23

Move client to API Trending #23

piazzatron commented Sep 25, 2020 •

edited

Loading

audius-infra commented Sep 25, 2020

jowlee left a comment

jowlee Sep 25, 2020

raymondjacobson Sep 26, 2020

jowlee Sep 25, 2020

jowlee Sep 25, 2020

Move client to API Trending #23

Move client to API Trending #23

Conversation

piazzatron commented Sep 25, 2020 • edited Loading

Trello Card Link

Description

Dragons

How Has This Been Tested?

audius-infra commented Sep 25, 2020

jowlee left a comment

Choose a reason for hiding this comment

jowlee Sep 25, 2020

Choose a reason for hiding this comment

raymondjacobson Sep 26, 2020

Choose a reason for hiding this comment

jowlee Sep 25, 2020

Choose a reason for hiding this comment

jowlee Sep 25, 2020

Choose a reason for hiding this comment

piazzatron commented Sep 25, 2020 •

edited

Loading