This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Use libs discprov makeRequest when available #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this change https://frontend-demo.audius.co/rj-bugfix |
piazzatron
approved these changes
Oct 14, 2020
| if (this.initializationState.state !== 'initialized') | ||
| throw new Error('_constructURL called uninitialized') | ||
|
|
||
| if (this.initializationState.type === 'libs' && window.audiusLibs) { |
There was a problem hiding this comment.
Any particular reason we're using window.audiusLibs instead of passings libs via constructor?
There was a problem hiding this comment.
we don't actually have libs defined at the time of construction, so we do need to reference some sort of global
| throw new Error('_constructURL called uninitialized') | ||
|
|
||
| if (this.initializationState.type === 'libs' && window.audiusLibs) { | ||
| const data = await window.audiusLibs.discoveryProvider._makeRequest({ |
There was a problem hiding this comment.
don't have to do this now, but I guess makeRequest shouldn't have the underscore prefix since it's no longer private to libs
| queryParams: params | ||
| }) | ||
| // TODO: Type boundaries of API | ||
| return { data } as any |
There was a problem hiding this comment.
What happens if we get a 404 from the new endpoints via libs? We still need to make sure those are coerced to null rather than propagating the error to our sagas
also I think this could be { data } as T probably?
There was a problem hiding this comment.
If it does fail (after it tries a bunch of things), it returns null :)
{ data } as T doesn't work unf. i tried for a while to get it to, but
Conversion of type '{ data: any; }' to type 'T' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
'T' could be instantiated with an arbitrary type which could be unrelated to '{ data: any; }'
There was a problem hiding this comment.
I think it's b/c data any implicitly
| return { data } as any | ||
| } | ||
|
|
||
| const resource = this._constructUrl(path, params) | ||
| const response = await fetch(resource) |
There was a problem hiding this comment.
I'm guessing we can't use the libs eager discprov selection logic and we still need this path huh
There was a problem hiding this comment.
we do use eager selection! just after libs is initted, we stop using it
sddioulde
pushed a commit
that referenced
this pull request
Sep 29, 2021
sliptype
pushed a commit
that referenced
this pull request
Feb 11, 2022
sliptype
pushed a commit
that referenced
this pull request
Feb 12, 2022
sliptype
pushed a commit
that referenced
this pull request
Feb 12, 2022
* Clean up dynamic image flashing * Use libs discprov makeRequest after eager selection * Fix simplebars
Kyle-Shanks
added a commit
that referenced
this pull request
Jun 9, 2022
* init create-react-library@2.6.7 * Initial commit * Add storybook and Scrubber * Update readme * Fixups * Update readme * Update image size * Update scrubber to fix staleness while dragging bug * Fixup example app * Fix scrubber and rollup config * Clean up * Clean up hook * Update readme * Cleanup scrubber * Rename uniqueKey * Clean up and fix scrubber touch events/safari issues * Add isDisabled back * Bump version * Fix scrubber timestamps (#2) * Fix scrubber for longer than one hour * 0.1.2 * Reformat * Add window focus event listener to fix scrubber (#3) * Add window focus event listener to fix scrubber * 0.1.3 * Add timeData ref * Remove usecallback * Add dark mode to stems (#4) * Add dark mode to stems * 0.1.4 * Bedtime (#5) * Scrubber changes for bedtime * Fix bedtime styles * Add disabled check Co-authored-by: Michael Piazza <michael.piazza.mp@gmail.com> * Add button & icons (#6) * Add Button Component * Clean up and fix lint * Fix iconShare * Export ButtonProps * 0.1.6-dev.0 * Add memo and remove listener * Fix lint situation * Clean up styles and add hooks * Remove memo * 0.1.6 * Extract css (#7) * Extract css separately * 0.2.0 * Add website and donate icons (#8) * Add dwebsite and donate icons * 0.2.1 * Added Trending & campfire icons & udpated pkg lock * 0.2.2 * Updated campfire/trending icons * Add handle color override & fix global var support (#10) * Add handle color override * 0.2.3 * Rework font support and fix inclusion of global vars * Remove logo * Update README.md (#12) * Update README.md * Bold notice text * Add LICENSE (#13) * Fix button animations, exposing animation vars (#14) * 0.2.4 (#15) * Adds modal and tab slider component (#16) * Adds modal and tab slider * Nest modal in another div * 0.2.5 (#17) * Add token value slider and input (#18) * 0.2.6 (#19) * Fix btn and slider (#20) * Fix btn and slider * 0.2.7 * Allow styling of TokenValueSlider bar (#21) * Allow styling of slider bar * 0.2.8 * Add specific color overrides for TokenValueSlider (#22) * Add specific color overrides for TokenValueSlider * 0.2.9 * Fix css var identifier * 0.2.10 * Numeric check in TokenValueInput (#23) * Update numeric check in TokenValueInput * 0.2.11 * Add z-index prop to modal (#24) * Add z-index to modal * 0.2.12 * Fix bug in modal (#25) * Rework modal to support all client use cases (#26) * Add scroll counter to modal itself * Fix up modal to support dapp * Fix useClickOutside catch and useGlobal for scroll count * Use useEffect to set initial * Add useEffect and lint * 0.3.0 (#27) * Fix click outside bug in modal (#28) * 0.3.1 (#29) * [AUD-17] useGlobal fix (#31) * 0.3.2-dev.0 * 0.3.2 * [AUD-17] Fix use global memoization * [AUD-9] Fix modal multi-line title on Safari (#30) * Use modal absolute position only on ios safari (#32) * Use absolute position only on ios safari * 0.3.3 * Fix typo * [AUD-112] Fix scrollable modals on iOS (#33) * Fix modal cleaup bg overflow (#35) * Fix modal cleaup bg overflow * Update comment on modal cleanup * 0.3.4 (#34) * Matrix Button Fix (#36) * Matrix fix * 0.3.5 * Additional changes * Add crown icon (#37) * Add crown * 0.3.6 * Slider Changes (#38) * Tab Slider changes * 0.3.7 * Change overflow to auto instead of scroll to hide if not needed (#39) * 0.3.8 (#40) * Expose shadow (#41) * Expose shadow * Update slider vars * 0.3.9 * Update storybook (#42) * Add deployer cut and minimum icons (#43) * 0.3.10 (#44) * Add TikTok icons (#45) * Add TikTok icons * Update inverted icon * 0.3.11 (#46) * Add Popup and PopupMenu (#47) * Update storybook * Update directory structure, nesting components * Add linting for import order and default exports * Add Popup * Add PopupMenu * Fix icon styling * Update paths * [WIP] Update PopupMenu * Minor tweaks to popup * Improve popup styling and logic * Remove duplicate Button.stories.tsx * Remove duplicate Scrubber.stories.tsx * Implement changes from PR comments * Add listener to close Popup on escape * Add back missing scrubber handle height (#48) * Add forward refs to Popup and PopupMenu (#49) * Add a forward ref to Popup and PopupMenu * Use named functions so ref-forwarded components are named in dev tools * 0.3.12 (#50) * Add eth and sol logos (#51) * 0.3.13 (#52) * Use react-spring transition config to animate popup (#53) * Add ProgressBar component (#54) * Add ProgressBar component * Update ProgressBar component to support BN and use BN under the hood * Add ref to Modal (#55) * 0.3.14 (#56) * Export ProgressBar component and bump version to 0.3.15 (#57) * Update TabSlider component (#58) * Add lock icon (#60) * Update LICENSE (#59) * 0.3.16 (#61) * [AUD-1026] Prevent escape from doing anything when a modal is closed (#63) * Update icon verified to have a path for the check mark (#62) * [AUD-900] Improve popup component (#64) * [AUD-900] Improve popup component * Address comments * 0.3.17 (#65) * Fix null types (#69) * 0.3.18 (#70) * Pin react version (#71) * Pin react version * Update react scripts * Upgrade to react@17.0.2 (#77) * [AUD-1351] Improve bundle size (#78) * Fix disabled button, update install instructions (#81) * 0.3.19 (#83) * [AUD-1359] Fix button label and buttonType (#84) * [AUD-1362] Fix modal a11y (#85) - Adds dialog role - Adds aria-labelledby and aria-describedby for title and subtitle * 0.3.20 (#86) [f2c470b] [AUD-1362] Fix modal a11y (#85) Dylan Jeffers [5d78444] [AUD-1359] Fix button label and buttonType (#84) Dylan Jeffers * Add gradient colors to theme vars (#87) * [AUD-1394] Fix window resize modal bug (#88) * 0.3.21 (#89) * Add Icons and Svg Backgrounds stories (#92) * add icons story * add source Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Rename Tabslider -> SegmentedControl; add Modal sub components (#93) * rename tabslider to segmentedcontrol * add modal story and modalContent component * file name fix * decomp Modal into sub components * changes to modal design, add icon folder * review * get rid of extra lines Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * small primary button update (#94) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.22 (#95) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * fix icons fill colors (#100) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.23 (#101) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * fix icons fill colors and add outlined variant of folder icon (#103) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.24 (#104) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Add Scrollbar component (#107) * add scrollbar component * fix import Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.25 (#109) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Add polyfill for resize observer (#110) * add polyfill for resize observer * add dep * pin dep Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.26 (#111) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * smoll css changes for scrollbar (#112) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.27 (#115) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * modal changes and add icon button (#113) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Upgrade storybook and add A11y add on (#114) * upgrade storybook and add a11y * run prettier eslintrc Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.28 (#116) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Add on blur callback and isWhole prop for whole numbers (#118) Co-authored-by: Saliou Diallo <saliou@audius.co> * 0.3.29 (#119) Co-authored-by: Saliou Diallo <saliou@audius.co> * Set button text to be static white on hover and add button icon transition (#122) * 0.3.30 (#123) * Add primary-secondary-text-color and update PopupMenu and Button text and icon colors to use it (#124) * 0.3.31 (#125) * Add role and aria-valuenow attributes to ProgressBar (#126) * 0.3.32 (#127) * add at sign icon (#128) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.33 (#129) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * fix disabled button states (#130) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.34 (#131) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * add transforms file to dist css (#132) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.35 (#133) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Hide scrollbar after delay [C-550] (#134) * hide scrollbar after delay * change transition * more specificity * fix id * remove comment Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * 0.3.36 (#135) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Use click instead of mousedown for listener (#136) * Use click instead of mousedown for listener * Only dismiss on click outside if modal is open * Fix boolean logic, add comment * edit comment * 0.3.37 (#137) * Add stems link to the readme Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: Michael Piazza <michael.piazza.mp@gmail.com> Co-authored-by: jowlee <joeylee0925@gmail.com> Co-authored-by: Sebastian Klingler <sliptype@gmail.com> Co-authored-by: Marcus Pasell <rickyrombo@users.noreply.github.com> Co-authored-by: Dylan Jeffers <dylan@audius.co> Co-authored-by: nicoback2 <36916764+nicoback2@users.noreply.github.com> Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Saliou Diallo <sddioulde@hotmail.com> Co-authored-by: Saliou Diallo <saliou@audius.co>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card Link
https://trello.com/c/inyb5DjL/1609-fix-full-models-to-include-signatures-remove-sigs-from-health-check
Description
Switches from
fetchto libs'axiosmake request after eager initial loadDragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
impacts everything after initial load
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
manually ran dapp against staging. verified that libs is invoked, but requests are the same!