-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
Preview this change https://demo.audius.co/amendel-attribution-modal-form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Super clean component structure and styles
border-radius: 8px; | ||
border: 1px solid var(--neutral-light-8); | ||
background: var(--neutral-light-10); | ||
text-transform: capitalize; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The designs don't have this text-transform from what I can tell
@@ -0,0 +1,57 @@ | |||
.row { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a fan of this but we could generalize it even further by putting these into their own file, like common classes
defaultSelected={derivativeWorks} | ||
// @ts-ignore boolean support works | ||
options={derivativeWorksValues} | ||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty annoying that we have to do this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's fixable but involves rewriting a bunch of stuff I think. I tried fooling with the types, but we'd have to ts-ignore in the SegmentedControl component instead. Maybe better? idk
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
688750 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.dev | View secret |
688750 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.prod | View secret |
2460749 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.prod | View secret |
688750 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.stage | View secret |
2416684 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.stage | View secret |
688750 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.dev | View secret |
688750 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.prod | View secret |
2460749 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.prod | View secret |
688750 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.stage | View secret |
2416684 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.stage | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Preview this change https://demo.audius.co/amendel-attribution-modal-form |
[5e99303] Add favorite test and fix aria-label (#3817) Raymond Jacobson [ccc32ce] [C-2908 C-2744] fix desktop follow button (#3816) Dylan Jeffers [c0679c3] [PAY-1660] Fix layout issues with TrackTile socials row with a lot of stats (#3815) Randy Schott [089a9e6] Pin stripe package versions (#3813) Reed [a281267] [C-2774] Update upload inputs (#3806) Dylan Jeffers [f504ef9] [C-2901] Fix menu types (#3811) Dylan Jeffers [cb9a385] [C-2905] Update Text types and props to camelCase (#3810) Kyle Shanks [027b3a5] [PAY-1624] Implement Purchase modal (#3808) Randy Schott [deadb5f] [C-2902] Update the upload forms to use the typography component (#3809) Kyle Shanks [039c951] [C-801] Fix oauth nodes (#3807) Raymond Jacobson [c3765c7] Update typography component to use classnames (#3805) Kyle Shanks [cab0a3e] Switch to Stripe package instead of script (#3798) Reed [a84126f] [C-2890] Add first version of a typography component to web (#3796) Kyle Shanks [4addddc] Fix mobile prem-content drawer unlocking margin (#3804) Reed [233b585] [C-2857] Remove get blocknumber (#3802) Dylan Jeffers [d113bdb] Prepare for 1.5.34 full app release (#3801) Dylan Jeffers [2f09db4] [C-2887] Fix collection button widths (#3800) Dylan Jeffers [8158e10] [PAY-1655] Add ColorValue prop to Text component (#3799) Reed [fe4bc6a] Revert cacheActions.add thunk (#3797) Dylan Jeffers [2370bbe] [PAY-1650] Update play/preview buttons on track details to use HarmonyButton (#3795) Randy Schott [3579dc2] [PAY-1651] Implements Harmony Buttons (#3794) Randy Schott [5af77ec] [C-2886] Improve cache performance (#3792) Dylan Jeffers [6fb78f1] [PAY-1587] Mobile USDC Purchase Drawer Skeleton (#3793) Reed [1277a41] [C-2883] Migrate confirmer to common (#3788) Dylan Jeffers [ce2548e] [plat-1111] add usdc purchase seller and buyer notifications (#3770) sabrina-kiam [bc04f52] Fix mobile LockedStatusBadge padding (#3790) Reed [8943078] [C-2680] Attribution Modal (#3778) Andrew Mendelsohn
Description
Feature Flags
UPLOAD_REDESIGN_ENABLED