This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Switch to Stripe package instead of script #3798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schottra
approved these changes
Jul 25, 2023
| if (!STRIPE_PUBLISHABLE_KEY) { | ||
| throw new Error('Stripe publishable key not found') | ||
| } | ||
| const stripeOnRampInstance = await loadStripeOnramp( |
There was a problem hiding this comment.
Function was already async and using an await so I wouldn't sweat it.
Just worth noting that event handlers aren't going to block on async functions. If I understand correctly, most of this code is going to run after the click handler has had a chance to finish it's capture/bubble cycle and return back to React.
|
@dharit-tan For your second question: Yes, we should definitely log out errors so we can catch any issues when we deploy it. |
|
cc @dylanjeffers to check out |
rickyrombo
approved these changes
Jul 25, 2023
| @@ -83,6 +83,8 @@ | |||
| "@sentry/integrations": "6.16.1", | |||
| "@solana/spl-token": "0.1.8", | |||
| "@solana/web3.js": "1.53.0", | |||
| "@stripe/crypto": "0.0.4", | |||
| "@stripe/stripe-js": "^1.54.1", | |||
There was a problem hiding this comment.
@rickyrombo as in should or should not pin?
There was a problem hiding this comment.
@dharit-tan hmm these aren't pinned in main, can you pin?
Good news is any |
|
Preview this change https://demo.audius.co/rt-stripe |
dylanjeffers
approved these changes
Jul 26, 2023
|
Preview this change https://demo.audius.co/rt-stripe |
schottra
added a commit
that referenced
this pull request
Jul 27, 2023
* origin/main: [C-801] Fix oauth nodes (#3807) Update typography component to use classnames (#3805) Switch to Stripe package instead of script (#3798) [C-2890] Add first version of a typography component to web (#3796) Fix mobile prem-content drawer unlocking margin (#3804) [C-2857] Remove get blocknumber (#3802) Prepare for 1.5.34 full app release (#3801)
audius-infra
pushed a commit
that referenced
this pull request
Jul 29, 2023
[5e99303] Add favorite test and fix aria-label (#3817) Raymond Jacobson [ccc32ce] [C-2908 C-2744] fix desktop follow button (#3816) Dylan Jeffers [c0679c3] [PAY-1660] Fix layout issues with TrackTile socials row with a lot of stats (#3815) Randy Schott [089a9e6] Pin stripe package versions (#3813) Reed [a281267] [C-2774] Update upload inputs (#3806) Dylan Jeffers [f504ef9] [C-2901] Fix menu types (#3811) Dylan Jeffers [cb9a385] [C-2905] Update Text types and props to camelCase (#3810) Kyle Shanks [027b3a5] [PAY-1624] Implement Purchase modal (#3808) Randy Schott [deadb5f] [C-2902] Update the upload forms to use the typography component (#3809) Kyle Shanks [039c951] [C-801] Fix oauth nodes (#3807) Raymond Jacobson [c3765c7] Update typography component to use classnames (#3805) Kyle Shanks [cab0a3e] Switch to Stripe package instead of script (#3798) Reed [a84126f] [C-2890] Add first version of a typography component to web (#3796) Kyle Shanks [4addddc] Fix mobile prem-content drawer unlocking margin (#3804) Reed [233b585] [C-2857] Remove get blocknumber (#3802) Dylan Jeffers [d113bdb] Prepare for 1.5.34 full app release (#3801) Dylan Jeffers [2f09db4] [C-2887] Fix collection button widths (#3800) Dylan Jeffers [8158e10] [PAY-1655] Add ColorValue prop to Text component (#3799) Reed [fe4bc6a] Revert cacheActions.add thunk (#3797) Dylan Jeffers [2370bbe] [PAY-1650] Update play/preview buttons on track details to use HarmonyButton (#3795) Randy Schott [3579dc2] [PAY-1651] Implements Harmony Buttons (#3794) Randy Schott [5af77ec] [C-2886] Improve cache performance (#3792) Dylan Jeffers [6fb78f1] [PAY-1587] Mobile USDC Purchase Drawer Skeleton (#3793) Reed [1277a41] [C-2883] Migrate confirmer to common (#3788) Dylan Jeffers [ce2548e] [plat-1111] add usdc purchase seller and buyer notifications (#3770) sabrina-kiam [bc04f52] Fix mobile LockedStatusBadge padding (#3790) Reed [8943078] [C-2680] Attribution Modal (#3778) Andrew Mendelsohn
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed the TODO so figured might as well.
Dragons
Not sure if
awaitinhandleClickis kosher but seems to work. Also not sure if we want to log out the errors to sentry.How Has This Been Tested?
Screen.Recording.2023-07-25.at.4.44.23.PM.mov
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.