-
Notifications
You must be signed in to change notification settings - Fork 43
[PAY-1592] Wire up USDC purchase flow on mobile #3881
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
688750 | Generic High Entropy Secret | 9a326ac | packages/mobile/.env.stage | View secret |
2416684 | Generic High Entropy Secret | 9a326ac | packages/mobile/.env.stage | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype |
Preview this change https://demo.audius.co/rt-wire-up-usdc-mobile |
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype |
Preview this change https://demo.audius.co/rt-wire-up-usdc-mobile |
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype |
Preview this change https://demo.audius.co/rt-wire-up-usdc-mobile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
} | ||
} | ||
|
||
function* handleCancelStripeOnramp() { | ||
const { onrampCanceled } = yield* select(getStripeModalState) | ||
yield* put(setVisibility({ modal: 'StripeOnRamp', visible: false })) | ||
yield* put(setVisibility({ modal: 'StripeOnRamp', visible: 'closing' })) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this from the recent modal changes @rickyrombo did? Or what motivated changing this to a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not related to my change. Ideally, we wouldn't set this manually like this but have some hook generate the 'closing'
vs false
for you, and you don't have to see or understand the difference. 'closing'
is distinct from false
in that 'closing'
means that it's in the process of closing (animating closed) and false
is that it's fully disappeared. This allowed @dylanjeffers to do conditional rendering of Modals to improve perf.
packages/mobile/src/components/premium-track-purchase-drawer/PremiumTrackPurchaseDrawer.tsx
Outdated
Show resolved
Hide resolved
...ges/mobile/src/components/premium-track-purchase-drawer/StripePurchaseConfirmationButton.tsx
Outdated
Show resolved
Hide resolved
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype |
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype |
Preview this change https://demo.audius.co/rt-wire-up-usdc-mobile |
[bd3fdc7] [C-2972] Fix feed, trending track-page seo (#3907) Dylan Jeffers [45279fe] [C-2969] Fix related artist images not loading (#3905) Andrew Mendelsohn [f51e6ac] [C-2961] Fix LeftNav SEO (#3906) Dylan Jeffers [6256792] Fix lint in useUserProfilePicture (#3903) Dylan Jeffers [f7dc55b] [C-2971] Add Avatar (#3902) Dylan Jeffers [ce441c1] [C-2970] Add Link, Improve Text (#3901) Dylan Jeffers [72fcc88] [PAY-1631] Implements post-purchase content on web (#3898) Randy Schott [0f28578] [C-2964] Cannonical URL should be uri encoded (#3899) Raymond Jacobson [3fca3c9] [C-2684 C-2955] Improve upload component hierarchy, state, and validation (#3891) Dylan Jeffers [3138da3] [PAY-1720] Implements PlainButton (#3897) Randy Schott [b353f94] Fix minor bugs for multi-track upload demo (#3854) Andrew Mendelsohn [22d4be5] Limit lines in Leaving Audius Modal (#3896) Marcus Pasell [b73b2f6] [C-2681, C-2682, C-2683] Add new upload finish page (#3890) Kyle Shanks [5d94b1f] [C-2914] USDC purchase options for new upload UI (web) (#3888) Andrew Mendelsohn [30cc8f1] Minor UI fixes for leaving audius modal (#3895) Marcus Pasell [970f411] Fix OAuth login page width (#3894) nicoback2 [deff919] Fix playlist form from crashing after double save (#3893) sabrina-kiam [18227f3] Update seo h1 to be accessibly hidden vs visually hidden (#3892) Dylan Jeffers [594b5c4] Move setCollectionPermalink within fetchCollectionSucceeded action (#3867) sabrina-kiam [9165c76] [plat-1055] revert legacy playlist route formatting in embed player to use permalink (#3824) sabrina-kiam [eb747cf] [PAY-1717] Make sign in/sign up page overlap banner (#3886) Marcus Pasell [2887342] [PAY-1658] Artist pick, hidden track tile tags moved to mid-left (#3889) Reed [2c80443] [C-2957] Add h1 tag for SEO (#3887) Raymond Jacobson [bae86c3] [C-2685 C-2686] Implement collection upload form (#3870) Dylan Jeffers [1c7ec6f] [PAY-1702] Use existing chats as default user list when sharing to DMs (#3877) Marcus Pasell [bf09344] [PAY-1701] Fix "Share to DMs" on mobile to go through InboxUnavailable modal (#3878) Marcus Pasell [9c9d7f4] [PAY-1700] Replace navigation if coming from ChatUserListScreen (#3879) Marcus Pasell [eaef4e6] [PAY-1588] Use existing balance in purchase flow on mobile (#3885) Reed [49d1d05] Add fb share page (#3876) Raymond Jacobson [46c33eb] Change nullish check to falsey check for collection track times (#3884) Kyle Shanks [b773045] Update twitter icon on mobile (#3880) Reed [dfc6c60] [PAY-1707] Implements usage of existing balance during content purchases (#3883) Randy Schott [5b4242f] [PAY-1592] Wire up USDC purchase flow on mobile (#3881) Reed [41cc4af] [PAY-1629] Purchase flow cleanup (#3873) Randy Schott
Description
E2e usdc purchase on mobile!
Depends on https://github.com/AudiusProject/audius-client/pull/3873/files
Dragons
How Has This Been Tested?
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-12.at.13.39.37.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-12.at.13.16.55.mp4
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.