This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[C-2964] Cannonical URL should be uri encoded #3899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See this link:
https://audius.co/withoutmoralbeat/my-march-love-|-analog-trap-beat-160-bpm-377952
view-source:https://audius.co/withoutmoralbeat/my-march-love-%7C-analog-trap-beat-160-bpm-377952
Sitemap does uri encoding for us, so this will ensure things match.
https://discoveryprovider.audius.co/sitemaps/track/9.xml
While another option may be to make permalinks come back from the API as uri encoded, I believe that it is nicer to leave this up to developer or else our multilanguage permalinks will look extraordinarily bad in API responses.
How Has This Been Tested?
Will ensure on stage via this track
https://staging.audius.co/ray65/%7C-%C3%B8%C7%83%C7%82%C7%86%C7%86%C7%86%CA%83%CA%84%CA%85%CA%86%CA%87%CA%88%CA%89%CA%8A%CA%8B%CA%8C%CA%8D%CA%8E%CA%8F%CA%90%CA%91%CA%92%CA%93%CA%94%CA%95%CA%96%CA%97%CA%98%CA%99%CA%9A%CA%9B%CA%9C%CA%9D%CA%9E%CA%9F%CA%A0%CA%A1%CA%A2%CA%A3%CA%A4%CA%A5%CA%A6%CA%A7%CA%A8%CA%A9%CA%AA%CA%AB%CA%AC%CA%AD%CA%AE%CA%AF-%60%60