Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

[PAY-1741] Add routes for transactional pages #3916

Merged
merged 1 commit into from
Aug 22, 2023
Merged

[PAY-1741] Add routes for transactional pages #3916

merged 1 commit into from
Aug 22, 2023

Conversation

schottra
Copy link
Contributor

Description

Just adding routes for now, will be used in follow-up PRs

Dragons

None, these routes are currently not handled in the router.

How Has This Been Tested?

Locally verified, 404s as expected

How will this change be monitored?

N/A

Feature Flags

N/A

@schottra schottra changed the title [PAY-1715] Add routes for transactional pages [PAY-1741] Add routes for transactional pages Aug 21, 2023
@AudiusProject AudiusProject deleted a comment from linear bot Aug 21, 2023
raymondjacobson
raymondjacobson approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. there should also be a spot where we prevent handles from being signed up with. lmk if you need a hand finding the code pointer

@schottra
Copy link
Contributor Author

nice. there should also be a spot where we prevent handles from being signed up with. lmk if you need a hand finding the code pointer

@raymondjacobson Yep, we use the orderedRoutes list as part of the larger restrictedRoutes list, which is used to validate handles at signup .

So this should already be...handled.

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/pay-1715-reserved-routes

@schottra schottra merged commit 6e303b1 into main Aug 22, 2023
2 checks passed
@schottra schottra deleted the pay-1715-reserved-routes branch August 22, 2023 04:10
audius-infra pushed a commit that referenced this pull request Aug 26, 2023
v1.5.39
b753006 
[b39cb5d] [PAY-1733] Remove Gated Prompt Modal (#3948) Marcus Pasell
[a522294] [PAY-1748][PAY-1731][PAY-1729][PAY-1730] DMs link fixes (#3946) Marcus Pasell
[adea357] quick linting fix (#3945) Kyle Shanks
[a0ff27c] Add embed cloudflare deployment and CI (#3940) Raymond Jacobson
[337f80f] [PAY-1727] USDC Withdrawals saga pt. 1 (#3932) Reed
[5bf820c] [C-2956] Add new Access & Sale modal to legacy upload form (#3900) Andrew Mendelsohn
[5258675] [C-2986] Upload flow qa round 1 (#3941) Kyle Shanks
[dd30c09] Use does_current_user_subscribe API field (#3943) Michelle Brier
[778a518] [C-2987] Add UserGeneratedText (#3942) Dylan Jeffers
[bb9e0cf] Update pull_request_template.md (#3939) Raymond Jacobson
[930dd1a] [C-2977] Fix collection page seo (#3936) Dylan Jeffers
[1e50b85] Update README.md (#3911) sabrina-kiam
[687fd28] Add lint check for console.log and remove some bad ones (#3930) Raymond Jacobson
[9f67e7b] [C-2968] Fix private collection action buttons (#3937) Dylan Jeffers
[7ab7a38] Fix canonical url consistency (#3938) Dylan Jeffers
[b1fbef8] [C-2689] Add upload confirmation modal (#3934) Kyle Shanks
[eb41fd3] [C-2966] Make sure that collection description limits are set to 1000 (#3935) Kyle Shanks
[6258484] Move sitemap hostname back to audius.co (#3931) Raymond Jacobson
[1e0c335] Client uses cids in requests to CN for images (#3882) Michelle Brier
[7974acc] Add library albums and playlists audius-query hook + migrate collection reformat util; bump SDK PAY-1679 (#3864) nicoback2
[7cba35b] [C-2982] Fix seo based on ahref recommendations (#3929) Dylan Jeffers
[05744b3] Migrate withdraw USDC saga to web common (#3928) Reed
[5d01710] USDC Withdrawal saga scaffolding (#3926) Reed
[4e0c480] Fix useAllPaginated query C-2980 (#3924) nicoback2
[21eb35c] Fix infinite scrolling cards C-2979 (#3923) nicoback2
[0025261] [PAY-1632] Clean up and improve performance of music confetti (#3921) Raymond Jacobson
[7ed2248] Revert "Update twitter icon on mobile (#3880)" (#3925) Reed
[1091934] [PAY-1742] Remove useMetaMask on invalid account (#3920) Raymond Jacobson
[6e303b1] [PAY-1741] Add routes for transactional pages (#3916) Randy Schott
[74cdb3c] Remove ontouchstart from index.html (#3919) Raymond Jacobson
[1a0332c] Improve lighthouse score (#3918) Raymond Jacobson
[a63896f] [PAY-1706] Merge modalsWithState with modals in common store (#3908) Marcus Pasell
[6a08944] [C-2976] Fix profile-page seo (#3912) Dylan Jeffers
[2381d46] Fix account details css (#3917) Raymond Jacobson
[8c24bdd] Fix mobile share of playlist permalink (#3913) sabrina-kiam
[1e376fe] [C-2911] Update new select page of the upload flow (#3910) Kyle Shanks
[bc0226f] Fix stripe modal opening behavior (#3914) Raymond Jacobson
[a3219c3] [C-2975] Fix stale local data (#3915) Dylan Jeffers
[748fdfd] PAY-1724 Add color specialGreen on mobile (#3909) Reed
[5c59fe5] [PAY-1628] Navigate to track after purchase (#3904) Randy Schott
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raymondjacobson raymondjacobson raymondjacobson approved these changes

@rickyrombo rickyrombo rickyrombo approved these changes

@dharit-tan dharit-tan dharit-tan approved these changes

Assignees

@raymondjacobson raymondjacobson

@rickyrombo rickyrombo

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schottra @audius-infra @raymondjacobson @rickyrombo @dharit-tan