Add embed cloudflare deployment and CI #3940

raymondjacobson · 2023-08-24T19:24:40Z

Description

Add embed deployment to cloudflare and CI.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

https://embed.audius.co/embed/playlist/DOPRl?flavor=card

local
npm run build:prod
npx wrangler preview --watch --env production

Viewable here:
https://embed.audius.co/embed/playlist/DOPRl?flavor=card

ci
run via this PR:
https://app.circleci.com/pipelines/github/AudiusProject/audius-client/16125/workflows/bab49d40-d813-4f08-815f-875030b59406

client

npx wrangler preview --watch --env production

Hitting https://example.com/embed/playlist/DOPRl?flavor=card yields the embed player!

socket-security · 2023-08-24T19:34:02Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@cloudflare/kv-asset-handler	0.0.12	None	`+0`	139 kB	imkmf

audius-infra · 2023-08-25T01:26:08Z

Preview this change https://demo.audius.co/rj-c-2991

audius-infra · 2023-08-25T02:30:44Z

Preview this change https://demo.audius.co/rj-c-2991

audius-infra · 2023-08-25T03:02:39Z

Preview this change https://demo.audius.co/rj-c-2991

audius-infra · 2023-08-25T03:55:27Z

Preview this change https://demo.audius.co/rj-c-2991

audius-infra · 2023-08-25T04:44:02Z

Preview this change https://demo.audius.co/rj-c-2991

audius-infra · 2023-08-25T05:35:25Z

Preview this change https://demo.audius.co/rj-c-2991

audius-infra · 2023-08-25T06:33:40Z

Preview this change https://demo.audius.co/rj-c-2991

audius-infra · 2023-08-25T08:06:54Z

Preview this change https://demo.audius.co/rj-c-2991

raymondjacobson · 2023-08-25T15:30:35Z

@sliptype i know one of the two of us will have to change some of this after your PR

raymondjacobson · 2023-08-25T15:31:43Z

.circleci/src/workflows/embed.yml

+      requires:
+        - embed-init
+      # filters:
+      #   branches:


sliptype

Yesss, good stuff

sliptype · 2023-08-25T15:33:22Z

.circleci/config.yml

@@ -11,7 +11,7 @@ commands:
          name: Combine package-lock.json files to single file and also adds a random value at the end to cache bust if needed
          command: |
            ls -d -- packages/*/*-lock.json | awk -F packages '{printf "\"packages%s\" ", $2}' | xargs cat > << parameters.filename >>
-            echo cache-bust-v1 >> <<parameters.filename >>
+            echo cache-bust-1692933717156 >> <<parameters.filename >>


Strange choice for the cache bust key but it's going away anyway

oh ok, cool. yeah i needed to bust and just did Date.now(). v1 confused me

sliptype · 2023-08-25T15:35:27Z

packages/embed/workers-site/package.json

@@ -0,0 +1,9 @@
+{
+  "private": true,
+  "version": "1.0.0",


Ah cool, no "name" field in here. That makes sense, I had to update the other workers sites names bc metro was complaining

audius-infra · 2023-08-25T17:22:16Z

Preview this change https://demo.audius.co/rj-c-2991

schottra · 2023-08-25T18:28:09Z

.circleci/src/commands/@embed-commands.yml

+        at: ./
+    - run:
+        name: build
+        no_output_timeout: 60m


schottra · 2023-08-25T18:29:17Z

.circleci/src/jobs/@embed-jobs.yml

+embed-build-staging:
+  working_directory: ~/audius-client
+  docker:
+    - image: circleci/node:14.18


@sliptype Is this something for us to keep an eye on with the node upgrade?

Yup, this is fine for now. Will do a follow up pr to bring embed up to 18!

schottra · 2023-08-25T18:30:15Z

packages/embed/README.md

@@ -14,12 +14,3 @@ npm run start:stage
 # Run against production Audius services
 npm run start:prod
 ```
-
-## Deploying


Minor nit: Is it worth mentioning here that deployment happens through CI? Or is that just generally known?

i think just generally known, but i can add some notes

schottra · 2023-08-25T18:31:41Z

packages/embed/workers-site/index.js

+  } catch (e) {
+    return new Response(e.message || e.toString(), { status: 500 })
+  }
+}


I'm going to assume most of this content is copied over from the previous implementation?
I don't know enough about the headers we are setting to catch any issues with it

yep, just defaults from cloudflare

[b39cb5d] [PAY-1733] Remove Gated Prompt Modal (#3948) Marcus Pasell [a522294] [PAY-1748][PAY-1731][PAY-1729][PAY-1730] DMs link fixes (#3946) Marcus Pasell [adea357] quick linting fix (#3945) Kyle Shanks [a0ff27c] Add embed cloudflare deployment and CI (#3940) Raymond Jacobson [337f80f] [PAY-1727] USDC Withdrawals saga pt. 1 (#3932) Reed [5bf820c] [C-2956] Add new Access & Sale modal to legacy upload form (#3900) Andrew Mendelsohn [5258675] [C-2986] Upload flow qa round 1 (#3941) Kyle Shanks [dd30c09] Use does_current_user_subscribe API field (#3943) Michelle Brier [778a518] [C-2987] Add UserGeneratedText (#3942) Dylan Jeffers [bb9e0cf] Update pull_request_template.md (#3939) Raymond Jacobson [930dd1a] [C-2977] Fix collection page seo (#3936) Dylan Jeffers [1e50b85] Update README.md (#3911) sabrina-kiam [687fd28] Add lint check for console.log and remove some bad ones (#3930) Raymond Jacobson [9f67e7b] [C-2968] Fix private collection action buttons (#3937) Dylan Jeffers [7ab7a38] Fix canonical url consistency (#3938) Dylan Jeffers [b1fbef8] [C-2689] Add upload confirmation modal (#3934) Kyle Shanks [eb41fd3] [C-2966] Make sure that collection description limits are set to 1000 (#3935) Kyle Shanks [6258484] Move sitemap hostname back to audius.co (#3931) Raymond Jacobson [1e0c335] Client uses cids in requests to CN for images (#3882) Michelle Brier [7974acc] Add library albums and playlists audius-query hook + migrate collection reformat util; bump SDK PAY-1679 (#3864) nicoback2 [7cba35b] [C-2982] Fix seo based on ahref recommendations (#3929) Dylan Jeffers [05744b3] Migrate withdraw USDC saga to web common (#3928) Reed [5d01710] USDC Withdrawal saga scaffolding (#3926) Reed [4e0c480] Fix useAllPaginated query C-2980 (#3924) nicoback2 [21eb35c] Fix infinite scrolling cards C-2979 (#3923) nicoback2 [0025261] [PAY-1632] Clean up and improve performance of music confetti (#3921) Raymond Jacobson [7ed2248] Revert "Update twitter icon on mobile (#3880)" (#3925) Reed [1091934] [PAY-1742] Remove useMetaMask on invalid account (#3920) Raymond Jacobson [6e303b1] [PAY-1741] Add routes for transactional pages (#3916) Randy Schott [74cdb3c] Remove ontouchstart from index.html (#3919) Raymond Jacobson [1a0332c] Improve lighthouse score (#3918) Raymond Jacobson [a63896f] [PAY-1706] Merge modalsWithState with modals in common store (#3908) Marcus Pasell [6a08944] [C-2976] Fix profile-page seo (#3912) Dylan Jeffers [2381d46] Fix account details css (#3917) Raymond Jacobson [8c24bdd] Fix mobile share of playlist permalink (#3913) sabrina-kiam [1e376fe] [C-2911] Update new select page of the upload flow (#3910) Kyle Shanks [bc0226f] Fix stripe modal opening behavior (#3914) Raymond Jacobson [a3219c3] [C-2975] Fix stale local data (#3915) Dylan Jeffers [748fdfd] PAY-1724 Add color specialGreen on mobile (#3909) Reed [5c59fe5] [PAY-1628] Navigate to track after purchase (#3904) Randy Schott

* origin/main: Fix Share to IG/T/S sticker consistency [C-3009] (#3949) v1.5.39 [PAY-1733] Remove Gated Prompt Modal (#3948) [PAY-1748][PAY-1731][PAY-1729][PAY-1730] DMs link fixes (#3946) quick linting fix (#3945) Add embed cloudflare deployment and CI (#3940) [PAY-1727] USDC Withdrawals saga pt. 1 (#3932) [C-2956] Add new Access & Sale modal to legacy upload form (#3900) [C-2986] Upload flow qa round 1 (#3941) Use does_current_user_subscribe API field (#3943) [C-2987] Add UserGeneratedText (#3942) Update pull_request_template.md (#3939) [C-2977] Fix collection page seo (#3936) Update README.md (#3911)

pull-request-size bot added the size/L label Aug 24, 2023

Add embed cloudflare deployment and CI

d67538a

raymondjacobson force-pushed the rj-c-2991 branch from bb9922a to d67538a Compare August 25, 2023 07:41

raymondjacobson requested review from schottra and sliptype August 25, 2023 15:30

raymondjacobson commented Aug 25, 2023

View reviewed changes

.circleci/src/workflows/embed.yml Outdated

requires:

- embed-init

# filters:

# branches:

Copy link

Member Author

raymondjacobson Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add back

sliptype approved these changes Aug 25, 2023

View reviewed changes

Add main filter back

8300828

schottra approved these changes Aug 25, 2023

View reviewed changes

Update README

6ac3f83

raymondjacobson merged commit a0ff27c into main Aug 25, 2023
2 checks passed

raymondjacobson deleted the rj-c-2991 branch August 25, 2023 19:32

AudiusProject deleted a comment from linear bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add embed cloudflare deployment and CI #3940

Add embed cloudflare deployment and CI #3940

raymondjacobson commented Aug 24, 2023 •

edited

Loading

socket-security bot commented Aug 24, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

raymondjacobson commented Aug 25, 2023

raymondjacobson Aug 25, 2023

sliptype left a comment

sliptype Aug 25, 2023

raymondjacobson Aug 25, 2023

sliptype Aug 25, 2023

raymondjacobson Aug 25, 2023

audius-infra commented Aug 25, 2023

schottra Aug 25, 2023

schottra Aug 25, 2023

sliptype Aug 25, 2023 •

edited

Loading

schottra Aug 25, 2023

raymondjacobson Aug 25, 2023

schottra Aug 25, 2023

raymondjacobson Aug 25, 2023

Add embed cloudflare deployment and CI #3940

Add embed cloudflare deployment and CI #3940

Conversation

raymondjacobson commented Aug 24, 2023 • edited Loading

Description

How Has This Been Tested?

socket-security bot commented Aug 24, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

audius-infra commented Aug 25, 2023

raymondjacobson commented Aug 25, 2023

Choose a reason for hiding this comment

sliptype left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

audius-infra commented Aug 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sliptype Aug 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raymondjacobson commented Aug 24, 2023 •

edited

Loading

sliptype Aug 25, 2023 •

edited

Loading