Fix validation on access and sale modal #3981

amendelsohn · 2023-08-30T21:23:05Z

Description

Fixes release-blocking issue with access and sale modal.

Fixes

Form was not able to be submitted when a validation error was present in other hidden fields
Cleans form values when swapping between availability types

How Has This Been Tested?

local web

rickyrombo

Noticed on stage I was unable to change access from gated to public and have it stick? Is that related?

rickyrombo · 2023-08-30T21:35:38Z

packages/web/src/pages/upload-page/fields/AccessAndSaleField.tsx

+        if (isPremiumContentUSDCPurchaseGated(formValues[PREMIUM_CONDITIONS])) {
+          return (
+            formValues[PREVIEW] === undefined ||
+            (formValues[PREVIEW] >= 0 && formValues[PREVIEW] < trackLength - 15)


fwiw it turns out track previews are implemented on the content end as 30s, so maybe easiest to update the UI side? Either way, maybe a comment/constant for the 15 here?

ah great call. I'll make it 30 before the end

audius-infra · 2023-08-30T21:38:47Z

Preview this change https://demo.audius.co/amendel-access-sale-regression-fix

amendelsohn · 2023-08-30T21:56:28Z

Noticed on stage I was unable to change access from gated to public and have it stick? Is that related?

Digging into this... looks like we're calling confirmEditTrack with premium_conditions: null and is_premium: false. Wondering if the null is getting dropped during the entity merge not replacing the premium conditions?

When the track reloads later, it has premium_conditions: { follower_id: 12345 } but is_premium: false, and the dog ear is visible but not the "Special Access" label

rickyrombo · 2023-08-30T21:59:16Z

Noticed on stage I was unable to change access from gated to public and have it stick? Is that related?

Digging into this... looks like we're calling confirmEditTrack with premium_conditions: null and is_premium: false. Wondering if the null is getting dropped during the entity merge not replacing the premium conditions?

When the track reloads later, it has premium_conditions: { follower_id: 12345 } but is_premium: false, and the dog ear is visible but not the "Special Access" label

That sounds like what's happening. https://github.com/AudiusProject/audius-protocol/blob/7b3120fd1da44563bd5530698ac91ab6c49a2594/discovery-provider/src/tasks/entity_manager/entities/track.py#L220-L226

Maybe we should send an empty object for premium conditions?

CC: @sliptype was that the intent with premium conditions check in entity_manager/track.py ?

dylanjeffers

Awesome. Now just checking the usdc field is hidden in prod anyway right?

packages/web/src/pages/upload-page/fields/AccessAndSaleField.tsx

dylanjeffers · 2023-08-30T22:12:42Z

packages/web/src/pages/upload-page/fields/AccessAndSaleField.tsx

@@ -109,12 +109,12 @@ const messages = {
  errors: {
    price: {
      tooLow: 'Price must be at least $0.99.',
-      tooHigh: 'Price must be less than $9.99.'
+      tooHigh: 'Price must be less than $9999.99.'


audius-infra · 2023-08-30T22:16:23Z

Preview this change https://demo.audius.co/amendel-access-sale-regression-fix

amendelsohn · 2023-08-30T22:42:58Z

Maybe we should send an empty object for premium conditions?

Oof sent premium_conditions: {} but still getting old premium_conditions: { follower_id: 123 } from discovery after confirmation.

amendelsohn · 2023-08-30T22:43:57Z

Awesome. Now just checking the usdc field is hidden in prod anyway right?

Correct, though the other bug affects prod track edit

[533affd] Commit package-lock sliptype [30596c5] Disable setup sliptype [a4af082] Disable branch filter sliptype [62c3391] Fix versions sliptype [60943ec] [C-3032] Fix collectible gated upload (#4012) Dylan Jeffers [bcf3473] [C-3035] Stale stats for offline tracks (#4010) Dylan Jeffers [6af2a34] Prepare 1.5.40 full app release (#4011) Dylan Jeffers [c19274a] [PAY-1791] Withdraw USDC - transfer to dest account (#4002) Reed [c36e63a] [C-3004] Scroll to top when switching tracks in upload (#4006) Andrew Mendelsohn [8c2966b] [C-3014] Add prompt on leaving upload form in progress (#3989) Andrew Mendelsohn [df42ea2] CI fixes for mobile (#4008) Sebastian Klingler [0d32111] [PAY-1723] Purchase content twitter share copy (#4005) Reed [a6585df] [PAY-1764] Update USDCCard icons in artist dashboard (#4003) Reed [92d839b] [C-3031] Fix transaction history numbers (#4001) Dylan Jeffers [2e6aef3] Remove unused TrackAvailabilityModal (#3994) Andrew Mendelsohn [6572576] [PAY-1734] Implement skeleton withdraw USDC modal (#3999) Raymond Jacobson [a1a2feb] [C-3017] Reset the new upload flow state when the upload button in the side nav is clicked (#4000) Kyle Shanks [294e7b3] [C-2954] Fix hashtag search (#3998) Dylan Jeffers [7587308] Add category to library query endpoint + more useAllPaginated fixes (#3975) nicoback2 [028e570] Fix CI (partially) (#3997) Sebastian Klingler [9b6c3e4] [C-2915] Implement Mobile USDC field (#3992) Dylan Jeffers [4e3c260] Fix AI learn more link (#3996) Reed [fe6cdbc] Fix misc embed deploy issues (#3995) Raymond Jacobson [42ca343] [C-3028] make the usdc inputs white (#3991) Andrew Mendelsohn [9f79838] [PAY-1776] Fix playing check for track page (#3993) Randy Schott [e0cd67d] [PAY-1591][PAY-1775] Implements content previews on native mobile (#3986) Randy Schott [a95a733] [C-2995] Add hint to modal radio items (#3990) Kyle Shanks [6b139db] [C-3029] Fix embed environment url (#3987) Dylan Jeffers [ec3a09d] [C-3022] Fix broken multi-track index after deleting (#3988) Andrew Mendelsohn [1ef154d] [PAY-1736] Implement new ArtistCard on dashboard (#3984) Raymond Jacobson [0df700b] Update files to account for changes on node 18 (#3985) Raymond Jacobson [d633a29] [PAY-1786] Withdraw USDC - create dest token account (#3982) Reed [fa060e2] [PAY-1755] Withdraw USDC flow: send signature to relay (#3980) Reed [b0d1d48] Add HarmonySelectablePill for mobile + Library filter pill menu (#3974) nicoback2 [cc723a1] Revert premium_conditions empty object change (#3983) Andrew Mendelsohn [7493cff] Fix validation on access and sale modal (#3981) Andrew Mendelsohn [a2b0890] Fix maxLength warning in search bar (#3979) Dylan Jeffers [9ba4c7b] [PAY-1761] Display USDC balance on artist dashboard (#3971) Reed [d47cd69] Fix TextField input spacing (#3978) Dylan Jeffers [83b7ae5] [PAY-1590] Hook up content previews for USDC content (#3968) Randy Schott [0ce85a2] [C-2921] Update subgenre value passed in the genre field (#3977) Kyle Shanks [c48179f] Fix text color for DMs (#3976) Marcus Pasell [559e50e] Improve sentry-cli usage in CI (#3972) Sebastian Klingler [0a4cca7] [PAY-1768] Convert artist dashboard to functional component (#3970) Reed [a171858] Fix embed ci with workspaces (#3969) Sebastian Klingler [bc73bef] Fix jupiter Buffer is not defined (#3967) Sebastian Klingler [3945552] [C-3026] Close now-playing when sharing to dm (#3966) Dylan Jeffers [8be4f39] [C-2999] Verify calendar input styles and update text when finalizing upload (#3965) Kyle Shanks [77aa099] [C-3020] Fix errors in usdc purchase field (#3964) Andrew Mendelsohn [c133a9c] [INF-445] Upgrade client to node 18, npm 9, and npm workspaces (#3927) Sebastian Klingler [650a6e2] [PAY-1506] USDC artist dashboard tile (#3963) Reed [68bba0d] [PAY-1715] Adds Sales page (#3957) Randy Schott [7d2f718] [PAY-1712] Implement purchases page (#3951) Randy Schott [314087b] [C-3025] Fix race-condition with stem/remix fetch (#3961) Dylan Jeffers [de2e27c] [C-3023] Fix collectible visibility (#3960) Dylan Jeffers [a0a5a84] [C-3012] Fix remixes deep link (#3958) Dylan Jeffers [9c2154c] [C-3018][C-2965] fix upload album/playlist description field styling (#3959) Andrew Mendelsohn [7cd1b00] [C-2791] Use artwork from the file if there is one (#3956) Andrew Mendelsohn [16c07ef] [C-3015] Add back button to new upload flow edit page (#3955) Kyle Shanks [353ca55] [C-2997] Disable delete on the last collection upload track (#3954) Kyle Shanks [f8dcd92] [C-3001, C-3003] Fix new upload flow error formatting (#3953) Kyle Shanks [4727ef4] [C-3000] Update audio file type icons (#3952) Kyle Shanks [1a2ce2a] [C-3002] Fix casing of selected values in upload flow (#3950) Kyle Shanks [dc3ed39] [C-3006][C-3005] Fix tag field wrapping (#3947) Andrew Mendelsohn [d047fda] Fix Share to IG/T/S sticker consistency [C-3009] (#3949) nicoback2

amendelsohn added 3 commits August 30, 2023 15:53

fix validaiton on legacy access and sale

c4ac350

fix availability type switching

d5f81fb

remove debug logs; lint fixes

8821d45

amendelsohn requested review from dylanjeffers and Kyle-Shanks August 30, 2023 21:23

pull-request-size bot added the size/L label Aug 30, 2023

rickyrombo approved these changes Aug 30, 2023

View reviewed changes

update thresholds

02bde6a

null out premium_conditions

00362e0

dylanjeffers approved these changes Aug 30, 2023

View reviewed changes

use {} for empty premium_conditions; fix limits

8968328

amendelsohn merged commit 7493cff into main Aug 30, 2023
2 checks passed

amendelsohn deleted the amendel-access-sale-regression-fix branch August 30, 2023 22:53

amendelsohn added a commit that referenced this pull request Aug 30, 2023

Fix validation on access and sale modal (#3981)

7df056c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix validation on access and sale modal #3981

Fix validation on access and sale modal #3981

amendelsohn commented Aug 30, 2023

rickyrombo left a comment

rickyrombo Aug 30, 2023

amendelsohn Aug 30, 2023

audius-infra commented Aug 30, 2023

amendelsohn commented Aug 30, 2023 •

edited

Loading

rickyrombo commented Aug 30, 2023 •

edited

Loading

dylanjeffers left a comment

dylanjeffers Aug 30, 2023

audius-infra commented Aug 30, 2023

amendelsohn commented Aug 30, 2023

amendelsohn commented Aug 30, 2023

Fix validation on access and sale modal #3981

Fix validation on access and sale modal #3981

Conversation

amendelsohn commented Aug 30, 2023

Description

How Has This Been Tested?

rickyrombo left a comment

Choose a reason for hiding this comment

rickyrombo Aug 30, 2023

Choose a reason for hiding this comment

amendelsohn Aug 30, 2023

Choose a reason for hiding this comment

audius-infra commented Aug 30, 2023

amendelsohn commented Aug 30, 2023 • edited Loading

rickyrombo commented Aug 30, 2023 • edited Loading

dylanjeffers left a comment

Choose a reason for hiding this comment

dylanjeffers Aug 30, 2023

Choose a reason for hiding this comment

audius-infra commented Aug 30, 2023

amendelsohn commented Aug 30, 2023

amendelsohn commented Aug 30, 2023

amendelsohn commented Aug 30, 2023 •

edited

Loading

rickyrombo commented Aug 30, 2023 •

edited

Loading