Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of divs and sections consistent #104

Closed
wants to merge 1 commit into from
Closed

Make use of divs and sections consistent #104

wants to merge 1 commit into from

Conversation

ccschmitz
Copy link

In a few places #primary is a <div>, and in others it's a <section>. This commit moves them all over to <section>'s, which is probably more appropriate.

In a few places #primary is a <div>, and in others it's a <section>.
This commit moves them all over to <section>'s, which I think is more
appropriate.
@BFTrick
Copy link
Contributor

BFTrick commented Feb 22, 2013

+1 to this. Converting the #primary div into a section makes sense.

@obenland
Copy link
Member

obenland commented Mar 2, 2013

As far as I'm concerned, we already use sections consistently. From the spec:

A section, [...] is a thematic grouping of content, typically with a heading.

The section element is not a generic container element. When an element is needed only for styling purposes or as a convenience for scripting, authors are encouraged to use the div element instead. A general rule is that the section element is appropriate only if the element's contents would be listed explicitly in the document's outline.

@obenland
Copy link
Member

No action in almost 4 weeks. Let's open a new ticket if there is disagreement with the direction _s takes on this, after #172 made it in.

@obenland obenland closed this Mar 26, 2013
@obenland obenland mentioned this pull request Aug 17, 2014
CostyEffe pushed a commit to silverbackstudio/wp-theme that referenced this pull request Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants