-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update archive.php #580
Update archive.php #580
Conversation
Revising the "primary" element to use a "div" vs. "section" to bring it into sync with index.php and single.php
Multiple points of feedback, in my opinion:
More broadly, there seems to be a strict interpretation of the spec, when in fact the spec itself is often ambiguous. This ambiguity suggests we should interpret the spec within the context of the overall theme, with the theme's organization and consistency taking precedent when there are conflicts with unclear aspects of the spec. |
If we had section titles in index or single, those divs would be sections too.
I believe the section's contents would be listed in the document's outline.
I think it is more important to use the right element for a given situation. Not necessarily the same ones. I still believe a section element in the context of archive pages is more fitting than a div, because in that context, it is not used as generic wrapper. It would be in index and single, which is why we don't use sections there. |
After looking closely at the specs, and the code, it is being used as a generic container, although not as generic as a bootstrap container. The specs also prescribe "identification of themes..." such as h1, h2, etc.. as a child of the section. The loop inside the section (or multiple loops) as is would generate 1 to N various sized header elements (in theory). Rendering the intention of the section element useless. |
Use `div`s consistently throughout templates.
Revising the "primary" element to use a "div" vs. "section" to bring it into sync with index.php and single.php