Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gallery Styles #429

Merged
merged 2 commits into from
Apr 14, 2014
Merged

Add Gallery Styles #429

merged 2 commits into from
Apr 14, 2014

Conversation

ScottSmith95
Copy link
Contributor

Patch for #425

@ScottSmith95
Add Gallery Styles
98c0f82 
Patch for #425
@obenland
Copy link
Member

obenland commented Mar 6, 2014

Thanks for the PR!

The styles you are suggesting are very much optimized for the needs of Twenty Thirteen, and not very generic. Do you think we can consolidate some of it and make them less opinionated?

@ScottSmith95
Copy link
Contributor Author

Absolutely! Would stripping the caption styles down to the minimum be a good start?

@obenland
Copy link
Member

obenland commented Mar 6, 2014

We probably don't need any captions styles, just the empty selector should be fine. Additionally we can remove the calculated max-width rules, the max-width for single column galleries, the .site-main prefixes since we don't have to override any core styles, the margins, etc.

@ScottSmith95
Copy link
Contributor Author

Thanks for the feedback, PR updated.

@ScottSmith95 ScottSmith95 mentioned this pull request Apr 2, 2014
Merged
@philiparthurmoore
Copy link
Collaborator

Relevant: https://core.trac.wordpress.org/changeset/27926

@obenland obenland mentioned this pull request Apr 11, 2014
Merged
@obenland obenland merged commit adb609b into Automattic:master Apr 14, 2014
obenland added a commit that referenced this pull request Apr 14, 2014
@obenland
Merge pull request #458 from Automattic/pr/429
2d2f66f 
Updated gallery styles to work for both HTML4 and HTML5 versions.

Fixes #425.
Closes #429.
@ScottSmith95 ScottSmith95 deleted the patch-1 branch April 14, 2014 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScottSmith95 @obenland @philiparthurmoore