-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Tiled Gallery Block: Update placeholder text #21620
[RNMobile] Tiled Gallery Block: Update placeholder text #21620
Conversation
With this commit, the placeholder text is changed from "ADD IMAGE" to "ADD MEDIA" (which is what the Gallery block has).
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually added the fix from #21625 in order to test this and it looks great on both platforms 🙇
Fixes wordpress-mobile/gutenberg-mobile#4195
With this PR, the placeholder text is changed from "ADD IMAGE" to "ADD MEDIA". This is to bring consistency with the text that's seen in other, similar blocks, such as the Gallery and Story blocks.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4194
Changes proposed in this Pull Request:
instructions
prop is used to update the block's default placeholder text. This matches up with how the placeholder text is set here in the Story block.Jetpack product discussion
Main project thread for the Tiled Gallery block on mobile: p9ugOq-1Tb-p2
Does this pull request change what data or activity we track or use?
No, it doesn't.
Testing instructions:
With these branches checked out and the Gutenberg Mobile demo app running, add the Tiled Gallery block. The placeholder text can be found within the default, empty block. It should be verified that the text reads "ADD MEDIA".