Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled Gallery Block: Update placeholder text #4194

Merged

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Nov 2, 2021

Fixes #4195

With this PR, the placeholder text is changed from "ADD IMAGE" to "ADD MEDIA". This is to bring consistency with the text that's seen in other, similar blocks, such as the Gallery and Story blocks.

Jetpack PR: Automattic/jetpack#21620

To test: Please refer to the Jetpack PR as the "central PR" with the most up-to-date testing instructions.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB changed the base branch from develop to add/tiled-gallery-block November 2, 2021 17:06
@SiobhyB SiobhyB changed the title Tiled Gallery Block: Update placeholder text for consistency with other blocks Tiled Gallery Block: Update placeholder text Nov 2, 2021
@SiobhyB SiobhyB added Tiled Gallery block Issues with this label will automatically appear on the project's board [Type] Enhancement Improves a current area of the editor labels Nov 2, 2021
@SiobhyB SiobhyB self-assigned this Nov 2, 2021
@SiobhyB SiobhyB marked this pull request as ready for review November 2, 2021 17:51
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB merged commit e60ce19 into add/tiled-gallery-block Nov 3, 2021
@SiobhyB SiobhyB deleted the update/tiled-gallery-placeholder-wording branch November 3, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tiled Gallery block Issues with this label will automatically appear on the project's board [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants