Gh 10423 adds a transform option to lean queries #11814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Dependency Review GitHub Action in your repository to enforce dependency > reviews on your pull requests. > The action scans for vulnerable versions of dependencies introduced by package version > changes in pull requests, > and warns you about the associated security vulnerabilities. > This gives you better visibility of what's changing in a pull request, > and helps prevent vulnerabilities being added to your repository. https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review#dependency-review-enforcement Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
When dealing with external schemas, i.e. a mongoose schema created inside another module, instanceOf may not work. This results in the value of ObjectIds in the schema being converted to strings when saving to the database.
fix(document): fix ObjectId conversion for external schemas
perf: improve isBsonType
chore(deps): Included dependency review
Fix codeql sec warnings
fix documention of error handling
improved issue templates
fix: typings of schemaTypeOptions should be a class
…populated in another doc with different unpopulatedValue Fix #11442
vkarpov15
requested changes
May 29, 2022
There was a problem hiding this comment.
Good job getting this working. I'm a little bummed that Mongoose doesn't handle calling completeOneLean() recursively already. But given that we need to do that, you should iterate through the schema's childSchemas to get subdocuments, rather than iterating through the entire object and assuming that any sub-objects you find are subdocuments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.