Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readConcern #14532

Closed
wants to merge 4 commits into from
Closed

readConcern #14532

wants to merge 4 commits into from

Conversation

IslandRhythms
Copy link
Collaborator

closes #14511

@IslandRhythms IslandRhythms requested a review from vkarpov15 April 22, 2024 18:59
lib/helpers/schema/applyReadConcern.js Outdated Show resolved Hide resolved
lib/helpers/schema/applyReadConcern.js Outdated Show resolved Hide resolved
options.readConcern.level = readConcern.level;
}
}
else {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This else {} statement does the exact same thing as the if {} branch above, please get rid of it

lib/query.js Outdated Show resolved Hide resolved
test/helpers/applyReadConcern.test.js Show resolved Hide resolved
@IslandRhythms IslandRhythms requested a review from vkarpov15 April 22, 2024 20:42
@Automattic Automattic deleted a comment from IslandRhythms Apr 22, 2024
@vkarpov15
Copy link
Collaborator

I'm just gonna close this PR and start from scratch, the work here is headed in the wrong direction

@vkarpov15 vkarpov15 closed this Apr 22, 2024
@vkarpov15 vkarpov15 deleted the IslandRhythms/gh-14511 branch April 22, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants