readConcern

lib/helpers/schema/applyReadConcern.js

@@ -0,0 +1,27 @@
+'use strict';
+
+const get = require('../get');
+
+module.exports = function applyReadConcern(schema, options) {
+  if (options.readConcern != null) {
+    return;
+  }
+  // Don't apply default write concern to operations in transactions,
+  // because setting write concern on an operation in a transaction is an error
+  // See: https://www.mongodb.com/docs/manual/reference/write-concern/
+  if (options && options.session && options.session.transaction) {
+    return;
+  }
+  const readConcern = get(schema, 'options.readConcern', {});
+  if (Object.keys(readConcern).length != 0) {
+    options.readConcern = {};
+    if (!('majoriy' in options) && readConcern.level != null) {
+      options.readConcern.level = readConcern.level;
+    }
+  }
+  else {
+    if (!('majoriy' in options) && readConcern.level != null) {
+      options.readConcern.level = readConcern.level;
+    }
+  }
+};

lib/model.js

@@ -68,6 +68,7 @@ const util = require('util');
 const utils = require('./utils');
 const MongooseBulkWriteError = require('./error/bulkWriteError');
 const minimize = require('./helpers/minimize');
+const applyReadConcern = require('./helpers/schema/applyReadConcern');
 
 const VERSION_WHERE = 1;
 const VERSION_INC = 2;
@@ -1982,6 +1983,7 @@ function _ensureIndexes(model, options, callback) {
     delete indexOptions._autoIndex;
     decorateDiscriminatorIndexOptions(model.schema, indexOptions);
     applyWriteConcern(model.schema, indexOptions);
+    applyReadConcern(model.schema, indexOptions);
     applySchemaCollation(indexFields, indexOptions, model.schema.options);
 
     indexSingleStart(indexFields, options);

lib/query.js

@@ -39,6 +39,7 @@ const specialProperties = require('./helpers/specialProperties');
 const updateValidators = require('./helpers/updateValidators');
 const util = require('util');
 const utils = require('./utils');
+const applyReadConcern = require('./helpers/schema/applyReadConcern');
 const queryMiddlewareFunctions = require('./constants').queryMiddlewareFunctions;
 
 const queryOptionMethods = new Set([
@@ -1311,6 +1312,19 @@ Query.prototype.writeConcern = function writeConcern(val) {
   return this;
 };
 
+/*
+Query.prototype.readConcern = function readConcern(val) {
+  console.log('what is val', val)
+  if (val == null) {
+    delete this.options.readConcern;
+    return this;
+  }
+
+  this.options.readConcern = val;
+  return this;
+}
+*/
+
 /**
  * Sets the specified number of `mongod` servers, or tag set of `mongod` servers,
  * that must acknowledge this write before this write is considered successful.
@@ -1946,7 +1960,7 @@ Query.prototype._optionsForExec = function(model) {
   }
   // Apply schema-level `writeConcern` option
   applyWriteConcern(model.schema, options);
-
+  applyReadConcern(model.schema, options);
   const readPreference = model &&
   model.schema &&
   model.schema.options &&

test/helpers/applyReadConcern.test.js

@@ -0,0 +1,22 @@
+'use strict';
+
+const assert = require('assert');
+const applyReadConcern = require('../../lib/helpers/schema/applyReadConcern');
+const start = require('../common');
+const mongoose = start.mongoose;
+
+describe('applyReadConcern', function() {
+  let db;
+  before(function() {
+    db = start();
+  });
+  after(async function() {
+    await db.close();
+  });
+  it('should not overwrite user specified read options (gh-14511)', async function() {
+    const options = { readConcern: { level: 'majority' } };
+    const testSchema = new mongoose.Schema({ name: String }, { readConcern: { level: 'majority ' } });
+    applyReadConcern(testSchema, options);
+    assert.deepStrictEqual({ readConcern: { level: 'majority' } }, options);
+  });
+});