Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/circleci build #214

Merged
merged 5 commits into from
Nov 1, 2021
Merged

Fix/circleci build #214

merged 5 commits into from
Nov 1, 2021

Conversation

miguelpeixe
Copy link
Member

Recent changes made to circleci/php:7.3-node-browsers resulted in our builds fail due to an incompatibility with our node-sass dependency.

circleci/ images are being deprecated and will lose support starting December 2021. We should start moving towards maintained images.

This PR implements the use of cimg/ images and changes the PHP extension install method from the docker-php-ext-install command to apt since the command is not supported on cimg/php:7.4.

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds seem fine, would be nice to test an alpha build as well for the release tasks.

Screen Shot 2021-11-01 at 1 53 09 PM

@miguelpeixe miguelpeixe merged commit 78da65e into master Nov 1, 2021
@miguelpeixe miguelpeixe deleted the fix/circleci-build branch November 1, 2021 20:04
matticbot pushed a commit that referenced this pull request Nov 1, 2021
## [1.18.1-alpha.1](v1.18.0...v1.18.1-alpha.1) (2021-11-01)

### Bug Fixes

* update circleci build images ([#214](#214)) ([78da65e](78da65e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.18.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants