Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update ci images #1210

Merged
merged 1 commit into from
Nov 1, 2021
Merged

fix: update ci images #1210

merged 1 commit into from
Nov 1, 2021

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

As seen on Automattic/newspack-ads#214, recent changes made to circleci/php resulted in our builds fail due to an incompatibility with our node-sass dependency.

circleci/ images are being deprecated and will lose support starting December 2021. We should start moving towards maintained images.

This PR implements the use of cimg/ images.

How to test the changes in this Pull Request:

CI tasks must pass.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 1, 2021
@miguelpeixe miguelpeixe requested a review from a team November 1, 2021 20:42
@miguelpeixe miguelpeixe self-assigned this Nov 1, 2021
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 1, 2021
@miguelpeixe miguelpeixe merged commit c476f08 into master Nov 1, 2021
@miguelpeixe miguelpeixe deleted the fix/circleci-build branch November 1, 2021 20:52
matticbot pushed a commit that referenced this pull request Nov 1, 2021
@semantic-release-bot
chore(release): 1.63.1-alpha.1 [skip ci]
f182887 
## [1.63.1-alpha.1](v1.63.0...v1.63.1-alpha.1) (2021-11-01)

### Bug Fixes

* update ci images ([#1210](#1210)) ([c476f08](c476f08))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.63.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 3, 2021
@semantic-release-bot
chore(release): 1.64.0 [skip ci]
b2f2e10 
# [1.64.0](v1.63.0...v1.64.0) (2021-11-03)

### Bug Fixes

* update ci images ([#1210](#1210)) ([c476f08](c476f08))

### Features

* parsely config manager ([#1207](#1207)) ([7f33cdb](7f33cdb))
* **ntg:** add NTG social events for reddit and telegram ([#1206](#1206)) ([bf2c589](bf2c589))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.64.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees

@miguelpeixe miguelpeixe

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelpeixe @matticbot @dkoo