Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NTG social event for reddit and telegram #1206

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Add NTG social event for reddit and telegram #1206

merged 1 commit into from
Nov 2, 2021

Conversation

yogeshbeniwal
Copy link
Contributor

@yogeshbeniwal yogeshbeniwal commented Oct 28, 2021 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Add NTG social event analytics for Reddit and Telegram. These are also used quite often by publishers and are supported by Jetpack.

How to test the changes in this Pull Request:

  1. Check out this PR
  2. Enable Reddit and Telegram in Jetpack sharing configuration
  3. Click on Reddit and Telegram icon on post/page to see event sent to analytics

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek requested a review from a team November 2, 2021 14:14
@adekbadek adekbadek merged commit bf2c589 into Automattic:master Nov 2, 2021
@adekbadek
Copy link
Member

Thank you @yogeshbeniwal !

@yogeshbeniwal yogeshbeniwal deleted the add-more-social-platform-analytics branch November 2, 2021 14:49
matticbot pushed a commit that referenced this pull request Nov 2, 2021
@semantic-release-bot
chore(release): 1.64.0-alpha.1 [skip ci]
3255f75 
# [1.64.0-alpha.1](v1.63.1-alpha.1...v1.64.0-alpha.1) (2021-11-02)

### Features

* parsely config manager ([#1207](#1207)) ([7f33cdb](7f33cdb))
* **ntg:** add NTG social events for reddit and telegram ([#1206](#1206)) ([bf2c589](bf2c589))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.64.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 3, 2021
@semantic-release-bot
chore(release): 1.64.0 [skip ci]
b2f2e10 
# [1.64.0](v1.63.0...v1.64.0) (2021-11-03)

### Bug Fixes

* update ci images ([#1210](#1210)) ([c476f08](c476f08))

### Features

* parsely config manager ([#1207](#1207)) ([7f33cdb](7f33cdb))
* **ntg:** add NTG social events for reddit and telegram ([#1206](#1206)) ([bf2c589](bf2c589))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.64.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yogeshbeniwal @adekbadek @matticbot