Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor for updating dependencies in newspack-scripts #860

Merged
merged 21 commits into from
Aug 2, 2024

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jun 14, 2024

All Submissions:

Changes proposed in this Pull Request:

Refactoring required for changes in Automattic/newspack-scripts#209. Note that this PR will not pass CI tests and should NOT be merged until Automattic/newspack-scripts#209 is released as an NPM package, so this repo can install it as a dependency.

How to test the changes in this Pull Request:

Follow instructions in Automattic/newspack-scripts#209.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added [Status] Needs Review dependencies Pull requests that update a dependency file Do not merge labels Jun 14, 2024
@dkoo dkoo self-assigned this Jun 14, 2024
@dkoo dkoo requested a review from a team as a code owner June 14, 2024 23:11
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts run well and smoke tests look good on both 6.6 and 6.5.4 👍

Approving assuming conflicts are resolved first.

Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested the changes related to the header bidding wizard and confirmed the creation and management of header bidding GAM orders are working without issues.

Thank you for taking care of these linting issues 🙇

@dkoo
Copy link
Contributor Author

dkoo commented Jul 30, 2024

Thanks for testing and approving, @miguelpeixe! Holding off on merging until we have a production version of the Newspack Scripts NPM package.

@dkoo dkoo removed the Do not merge label Aug 2, 2024
@dkoo dkoo merged commit 8e9e839 into trunk Aug 2, 2024
6 checks passed
@dkoo dkoo deleted the chore/update-dependencies branch August 2, 2024 20:34
matticbot pushed a commit that referenced this pull request Aug 2, 2024
# [3.0.0-alpha.1](v2.2.0-alpha.1...v3.0.0-alpha.1) (2024-08-02)

### Bug Fixes

* update dependencies to support `@wordpress/scripts` ([#860](#860)) ([8e9e839](8e9e839))

### BREAKING CHANGES

* Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version.

* fix: update deprecated v202305 GAM API to v202405

* fix: update composer platform dependency

* fix: less specific PHP version

* fix: lower PHP version

* chore: refactor for newspack-scripts dependency updates

* chore: changes for linting errors

* refactor: use proxy script for eslint and stylelint scripts

* chore: update newspack-scripts to v5.6.0-alpha.3

* chore: add .stylelintrc.js

* chore: update newspack-scripts to v5.6.0-alpha.4

* fix: add missing Prettier config files

* fix: reformat SCSS

* chore: update newspack-scripts to 5.6.0-alpha.5

* chore: update newspack-scripts to v5.6.0-alpha.7

* chore: update newspack-scripts to v5.6.0-alpha.8

* chore: add NPM scripts for PHP

* chore: update newspack-components to v3.0.0

* chore: bump newspack-scripts to v5.5.2
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 13, 2024
# [3.0.0](v2.1.0...v3.0.0) (2024-08-13)

### Bug Fixes

* update dependencies to support `@wordpress/scripts` ([#860](#860)) ([8e9e839](8e9e839))

### Features

* **GAM:** add Complianz consent integration to ad targeting ([#876](#876)) ([a95aebe](a95aebe))

### BREAKING CHANGES

* Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version.

* fix: update deprecated v202305 GAM API to v202405

* fix: update composer platform dependency

* fix: less specific PHP version

* fix: lower PHP version

* chore: refactor for newspack-scripts dependency updates

* chore: changes for linting errors

* refactor: use proxy script for eslint and stylelint scripts

* chore: update newspack-scripts to v5.6.0-alpha.3

* chore: add .stylelintrc.js

* chore: update newspack-scripts to v5.6.0-alpha.4

* fix: add missing Prettier config files

* fix: reformat SCSS

* chore: update newspack-scripts to 5.6.0-alpha.5

* chore: update newspack-scripts to v5.6.0-alpha.7

* chore: update newspack-scripts to v5.6.0-alpha.8

* chore: add NPM scripts for PHP

* chore: update newspack-components to v3.0.0

* chore: bump newspack-scripts to v5.5.2
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants