-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor for updating dependencies in newspack-scripts #860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts run well and smoke tests look good on both 6.6 and 6.5.4 👍
Approving assuming conflicts are resolved first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also tested the changes related to the header bidding wizard and confirmed the creation and management of header bidding GAM orders are working without issues.
Thank you for taking care of these linting issues 🙇
Thanks for testing and approving, @miguelpeixe! Holding off on merging until we have a production version of the Newspack Scripts NPM package. |
# [3.0.0-alpha.1](v2.2.0-alpha.1...v3.0.0-alpha.1) (2024-08-02) ### Bug Fixes * update dependencies to support `@wordpress/scripts` ([#860](#860)) ([8e9e839](8e9e839)) ### BREAKING CHANGES * Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version. * fix: update deprecated v202305 GAM API to v202405 * fix: update composer platform dependency * fix: less specific PHP version * fix: lower PHP version * chore: refactor for newspack-scripts dependency updates * chore: changes for linting errors * refactor: use proxy script for eslint and stylelint scripts * chore: update newspack-scripts to v5.6.0-alpha.3 * chore: add .stylelintrc.js * chore: update newspack-scripts to v5.6.0-alpha.4 * fix: add missing Prettier config files * fix: reformat SCSS * chore: update newspack-scripts to 5.6.0-alpha.5 * chore: update newspack-scripts to v5.6.0-alpha.7 * chore: update newspack-scripts to v5.6.0-alpha.8 * chore: add NPM scripts for PHP * chore: update newspack-components to v3.0.0 * chore: bump newspack-scripts to v5.5.2
🎉 This PR is included in version 3.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [3.0.0](v2.1.0...v3.0.0) (2024-08-13) ### Bug Fixes * update dependencies to support `@wordpress/scripts` ([#860](#860)) ([8e9e839](8e9e839)) ### Features * **GAM:** add Complianz consent integration to ad targeting ([#876](#876)) ([a95aebe](a95aebe)) ### BREAKING CHANGES * Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version. * fix: update deprecated v202305 GAM API to v202405 * fix: update composer platform dependency * fix: less specific PHP version * fix: lower PHP version * chore: refactor for newspack-scripts dependency updates * chore: changes for linting errors * refactor: use proxy script for eslint and stylelint scripts * chore: update newspack-scripts to v5.6.0-alpha.3 * chore: add .stylelintrc.js * chore: update newspack-scripts to v5.6.0-alpha.4 * fix: add missing Prettier config files * fix: reformat SCSS * chore: update newspack-scripts to 5.6.0-alpha.5 * chore: update newspack-scripts to v5.6.0-alpha.7 * chore: update newspack-scripts to v5.6.0-alpha.8 * chore: add NPM scripts for PHP * chore: update newspack-components to v3.0.0 * chore: bump newspack-scripts to v5.5.2
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Refactoring required for changes in Automattic/newspack-scripts#209. Note that this PR will not pass CI tests and should NOT be merged until Automattic/newspack-scripts#209 is released as an NPM package, so this repo can install it as a dependency.
How to test the changes in this Pull Request:
Follow instructions in Automattic/newspack-scripts#209.
Other information: