Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor for updating dependencies in newspack-scripts #860

Merged
merged 21 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 39 additions & 10 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,14 +1,43 @@
.DS_Store
# Editors
project.xml
project.properties
/nbproject/private/
.buildpath
.project
.settings*
.idea
.vscode
*.sublime-project
*.sublime-workspace
.sublimelinterrc

# NPM
.cache
Thumbs.db
wp-cli.local.yml
node_modules/
*.sql
*.tar.gz
*.zip
/node_modules/

# Sass
.sass-cache/

# OS X metadata
.DS_Store

dist/
# Windows junk
Thumbs.db

# Composer
/vendor/
release/
codecov

# Built files
/dist
/src/components/dist
/src/components/shared
/src/components/node_modules
release

# Tests
codecov/
coverage/
.phpunit.result.cache

# Misc
tsconfig.tsbuildinfo
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.11.1
lts/*
4 changes: 4 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
dist
node_modules
release
vendor
10 changes: 0 additions & 10 deletions .prettierrc

This file was deleted.

5 changes: 5 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
const baseConfig = require( './node_modules/newspack-scripts/config/prettier.config.js' );

module.exports = {
...baseConfig
};
9 changes: 9 additions & 0 deletions .stylelintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
module.exports = {
ignoreFiles: [
'dist/**',
'node_modules/**',
'release/**',
'scripts/**',
],
extends: [ './node_modules/newspack-scripts/config/stylelint.config.js' ],
};
2 changes: 1 addition & 1 deletion includes/bidders/class-medianet.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Ads plugin. For additional partners you must recompile Prebid.js and replace
* the `newspack-ads-prebid` enqueued script.
*
* See Newspack_Ads_Bidding::enqueue_scripts() and
* See Newspack_Ads_Bidding::enqueue_scripts() and
* `newspack-ads/src/prebid/index.js` for additional reference.
*
* More information on Prebid.js: https://github.com/prebid/Prebid.js/
Expand Down
Loading