-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(donate-block): allow spaces in button label #1479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, I got too fancy trying to inherit existing styles using an existing class name. But that class name has different styles depending on the "style" selected for the block. 250115f should make things consistent across all styles and layouts. |
🎉 This PR is included in version 1.71.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.72.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.72.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Fixes a minor but annoying bug in which the
RichText
component for the submit button in the editor for Donate blocks doesn't allow spaces if it's nested inside abutton
element. This fix changes thebutton
element to adiv
with the same styles, in the editor only. See also Automattic/newspack-newsletters#1202Closes
1204751246381643/1204483195828260
.How to test the changes in this Pull Request:
master
, add a Donate block to a post or page.Other information: