-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display purchase details in checkout modal when taxes are enabled #1480
feat: display purchase details in checkout modal when taxes are enabled #1480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described and fits well in the modal.
Maybe we can investigate in the future if we have more granular control on what to display to make it less verbose?
Thanks @leogermani! 🙌 |
🎉 This PR is included in version 1.71.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.72.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.72.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR adds the tax/order details table on the second screen of the modal checkout, if you have taxes enabled.
It also removes some cruft that came over from the theme's version of this template; the theme had options to hide this information outright, display it with a toggle, or show it all the time. We could also go that route; I was just leery of duplicating the setting, or tying it to something in the current theme if we can avoid it 😬
I also didn't do much with the styling; I tried to keep with the simplified appearance for this information, but it just felt more cluttered. The table's a straight copy of how this information displays in the theme.
See 1200550061930446-as-1204773493453836
How to test the changes in this Pull Request:
First enable and set up taxes.
Next, test the PR:
npm run build
.Other information: