-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal-checkout): render order details under different conditions #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
changed the title
feat(modal-checkout): feature parity with theme's order details options
feat(modal-checkout): render order details under different conditions
Jun 28, 2023
claudiulodro
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great solution. Works well and code looks solid.
miguelpeixe
added a commit
that referenced
this pull request
Jun 29, 2023
6 tasks
miguelpeixe
added a commit
that referenced
this pull request
Jun 29, 2023
matticbot
pushed a commit
that referenced
this pull request
Jul 7, 2023
# [1.73.0-alpha.1](v1.72.0...v1.73.0-alpha.1) (2023-07-07) ### Features * add updated translation files ([#1486](#1486)) ([3a44410](3a44410)) * allow Homepage Posts and Carousel blocks to include subcategories ([#1482](#1482)) ([faa8734](faa8734)) * **modal-checkout:** render order details under different conditions ([#1485](#1485)) ([ae62734](ae62734))
🎉 This PR is included in version 1.73.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jul 17, 2023
# [1.73.0](v1.72.2...v1.73.0) (2023-07-17) ### Features * add updated translation files ([#1486](#1486)) ([3a44410](3a44410)) * allow Homepage Posts and Carousel blocks to include subcategories ([#1482](#1482)) ([faa8734](faa8734)) * **modal-checkout:** render order details under different conditions ([#1485](#1485)) ([ae62734](ae62734))
🎉 This PR is included in version 1.73.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Implements a dynamic check on whether to render the order details for a modal checkout cart.
The following should render the order details table:
How to test the changes in this Pull Request:
Other information: