Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal-checkout): render order details under different conditions #1485

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Jun 26, 2023

All Submissions:

Changes proposed in this Pull Request:

Implements a dynamic check on whether to render the order details for a modal checkout cart.

The following should render the order details table:

How to test the changes in this Pull Request:

  1. Repeat steps from feat: display purchase details in checkout modal when taxes are enabled #1480
  2. Disable tax rates and calculations on WC settings (or switch the "display prices" in the "tax" tab to "including taxes")
  3. Enable coupons and create a coupon
  4. Click on the checkout button and confirm the order details do not render
  5. Apply the coupon and confirm the order details rendered with coupon details as the coupon is applied
  6. Go through the entire checkout process and confirm the order is placed

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe changed the title feat(modal-checkout): feature parity with theme's order details options feat(modal-checkout): render order details under different conditions Jun 28, 2023
@miguelpeixe miguelpeixe self-assigned this Jun 28, 2023
@miguelpeixe miguelpeixe marked this pull request as ready for review June 28, 2023 14:25
@miguelpeixe miguelpeixe requested a review from a team as a code owner June 28, 2023 14:25
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution. Works well and code looks solid.

@miguelpeixe miguelpeixe merged commit ae62734 into master Jun 29, 2023
@miguelpeixe miguelpeixe deleted the feat/modal-checkout-theme-parity branch June 29, 2023 12:18
matticbot pushed a commit that referenced this pull request Jun 29, 2023
# [1.71.0](v1.70.0...v1.71.0) (2023-06-29)

### Features

* **modal-checkout:** render order details under different conditions ([#1485](#1485)) ([#1488](#1488)) ([aa569ad](aa569ad))
matticbot pushed a commit that referenced this pull request Jul 7, 2023
# [1.73.0-alpha.1](v1.72.0...v1.73.0-alpha.1) (2023-07-07)

### Features

* add updated translation files ([#1486](#1486)) ([3a44410](3a44410))
* allow Homepage Posts and Carousel blocks to include subcategories ([#1482](#1482)) ([faa8734](faa8734))
* **modal-checkout:** render order details under different conditions ([#1485](#1485)) ([ae62734](ae62734))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.73.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 17, 2023
# [1.73.0](v1.72.2...v1.73.0) (2023-07-17)

### Features

* add updated translation files ([#1486](#1486)) ([3a44410](3a44410))
* allow Homepage Posts and Carousel blocks to include subcategories ([#1482](#1482)) ([faa8734](faa8734))
* **modal-checkout:** render order details under different conditions ([#1485](#1485)) ([ae62734](ae62734))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.73.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants