Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow order details wrapper to render #1547

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

#1516 introduced a regression by hiding the order details wrapper in the template. Since #1485 this has been handled dynamically, due to the dynamic nature of WC cart template fragments. Adding or removing coupons changes whether the order details should be rendered or not.

This PR removes the "hidden" class from the template so the fragment hook can determine whether to render details.

How to test the changes in this Pull Request:

  1. While on the release branch, checkout a product with the checkout button block and apply a coupon
  2. Confirm the coupon doesn't seem applied
  3. Check out this branch, try again, and confirm the UI updates and the coupon is applied

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Oct 4, 2023
@miguelpeixe miguelpeixe requested a review from a team as a code owner October 4, 2023 20:06
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thanks for catching!

@miguelpeixe miguelpeixe merged commit b76f196 into release Oct 4, 2023
9 checks passed
@miguelpeixe miguelpeixe deleted the hotfix/order-details-hidden branch October 4, 2023 20:27
matticbot pushed a commit that referenced this pull request Oct 4, 2023
## [1.75.2](v1.75.1...v1.75.2) (2023-10-04)

### Bug Fixes

* allow order details wrapper to render ([#1547](#1547)) ([b76f196](b76f196))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.75.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants