-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sure carousels without images aren't collapsed #1511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works,
But in some cases, the navigation arrow is over the author avatar:
Not sure if that's avoidable (and yes, I've got a bunch of posts named "About us")
Also @laurelfulford , I remember us discussing what should be the behavior of the carousel when none of the posts had images... I think the carouse wasn't being displayed at all.. and we changed that... Do you remember that?
# [1.74.0-alpha.2](v1.74.0-alpha.1...v1.74.0-alpha.2) (2023-08-24) ### Bug Fixes * make sure carousels without images aren't collapsed ([#1511](#1511)) ([ee8c1cd](ee8c1cd)) * reduce post carousel font size for 5-6 slides ([#1510](#1510)) ([daabad4](daabad4)) * support account creation on modal checkout ([#1516](#1516)) ([51ae19d](51ae19d))
🎉 This PR is included in version 1.74.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [1.74.0](v1.73.0...v1.74.0) (2023-08-24) ### Bug Fixes * make sure carousels without images aren't collapsed ([#1511](#1511)) ([ee8c1cd](ee8c1cd)) * reduce post carousel font size for 5-6 slides ([#1510](#1510)) ([daabad4](daabad4)) * support account creation on modal checkout ([#1516](#1516)) ([51ae19d](51ae19d)) ### Features * Merge pull request [#1509](#1509) from Automattic/master ([1280d07](1280d07))
🎉 This PR is included in version 1.74.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sorry I'm getting back to this so late @leogermani!
Kind of! I did some digging around to confirm: it looks like the carousel was updated so it didn't show anything if none of the posts had images here. After we got reports of this being confusing, it was changed to allow posts without images again here. |
All Submissions:
Changes proposed in this Pull Request:
This PR fixes an issue where the Post Carousel slider would be collapsed on the front-end if none of the posts had featured images.
See 1200550061930446-as-1204845439898529
How to test the changes in this Pull Request:
npm run build
.Other information: