Carousel: handle posts without featured images #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
requested changes
Apr 6, 2021
| @@ -66,28 +63,30 @@ function newspack_blocks_render_block_carousel( $attributes ) { | |||
| while ( $article_query->have_posts() ) : | |||
There was a problem hiding this comment.
If the carousel has no posts, I still see empty carousel UI on the front-end. At this point, if ! $article_query->have_posts(), we should just return early before the UI below line 220 gets rendered.
src/blocks/carousel/edit.js
Outdated
| className="swiper-pagination-bullets amp-pagination" | ||
| ref={ this.paginationRef } | ||
| /> | ||
| { ! hasNoPosts && ( |
There was a problem hiding this comment.
We should also not render the next/previous UI (buttons and bullets) if there's only one post, both here and on the front-end.
# Conflicts: # includes/class-newspack-blocks-api.php # src/blocks/carousel/edit.js # src/blocks/carousel/view.php
dkoo
approved these changes
Apr 6, 2021
|
🎉 This PR is included in version 1.23.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Apr 6, 2021
# [1.23.0](v1.22.1...v1.23.0) (2021-04-06) ### Features * add new patterns for donation and subscribe ([#730](#730)) ([a00cfd6](a00cfd6)) * deduplication across homepage posts & carousel ([#725](#725)) ([427c4e0](427c4e0)), closes [#664](#664) * handle posts with no featured image ([#731](#731)) ([0db34be](0db34be)), closes [#443](#443)
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes #443
How to test the changes in this Pull Request:
Other information: