-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ensure that membership plans have unique network id #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
chickenn00dle
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
matticbot
pushed a commit
that referenced
this pull request
Aug 1, 2024
# [1.11.0-alpha.1](v1.10.1...v1.11.0-alpha.1) (2024-08-01) ### Bug Fixes * **memberships-sync:** handle active subs from other nodes ([#114](#114)) ([97f9a58](97f9a58)) ### Features * **distributor:** sync comment status ([#116](#116)) ([5844853](5844853)) * ensure that membership plans have unique network id ([#108](#108)) ([d2d63a0](d2d63a0))
🎉 This PR is included in version 1.11.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Aug 13, 2024
# [2.0.0](v1.10.1...v2.0.0) (2024-08-13) ### Bug Fixes * **memberships-sync:** handle active subs from other nodes ([#114](#114)) ([97f9a58](97f9a58)) * update dependencies to support `@wordpress/scripts` ([#104](#104)) ([e9691b8](e9691b8)) ### Features * **distributor:** sync comment status ([#116](#116)) ([5844853](5844853)) * ensure that membership plans have unique network id ([#108](#108)) ([d2d63a0](d2d63a0)) ### BREAKING CHANGES * Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version. * chore: refactor for newspack-scripts dependency updates * chore: update composer * fix: peer dependencies * chore: update newspack-scripts to v5.6.0-alpha.3 * chore: update newspack-scripts to v5.6.0-alpha.4 * chore: remove unnecessary prettier config file * chore: update newspack-scripts to v5.6.0-alpha.7 * fix: update phpcs.xml * chore: bump newspack-scripts to v5.5.2
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One membership plan in one site should always map to one membership plan in the other sites.
This PRs make sure you don't allow users to set the same "network id" for more than one membership plan.
This is an alternative to #80
Testing
-2
-2
suffix added when it shouldn't